Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: check SharedArrayBuffer availability in freeze_intrinsics.js #49482

Merged
merged 1 commit into from
Sep 6, 2023
Merged

lib: check SharedArrayBuffer availability in freeze_intrinsics.js #49482

merged 1 commit into from
Sep 6, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 4, 2023

Upstreaming patch from electron/electron#38571

We would like to be able to use --frozen-intrinsics in the renderer process in Electron, which may not have SharedArrayBuffer enabled due to Chromium security policies.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 4, 2023
@miniak miniak changed the title fix: check SharedArrayBuffer availability in freeze_intrinsics.js lib: check SharedArrayBuffer availability in freeze_intrinsics.js Sep 4, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2023
@nodejs-github-bot nodejs-github-bot merged commit cfe4166 into nodejs:main Sep 6, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in cfe4166

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
PR-URL: #49482
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This was referenced Sep 28, 2023
@miniak miniak deleted the miniak/freeze_intrinsics branch September 30, 2023 17:16
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#49482
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants