esm: remove return value for Module.register
#49529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current API shape si not great because it's too limited and redundant with the use of `MessagePort`.
|
Review requested:
|
nodejs-github-bot
added
esm
GeoffreyBooth
approved these changes
Sep 7, 2023
aduh95
commented
Sep 7, 2023
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
GeoffreyBooth
approved these changes
Sep 7, 2023
26 tasks
JakobJingleheimer
approved these changes
Sep 8, 2023
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b64c3ee |
18 tasks
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
The current API shape si not great because it's too limited and redundant with the use of `MessagePort`. PR-URL: #49529 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
The current API shape si not great because it's too limited and redundant with the use of `MessagePort`. PR-URL: nodejs#49529 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
The current API shape si not great because it's too limited and redundant with the use of `MessagePort`. PR-URL: nodejs#49529 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The current API shape si not great because it's too limited and redundant with the use of `MessagePort`. PR-URL: nodejs/node#49529 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The current API shape si not great because it's too limited and redundant with the use of `MessagePort`. PR-URL: nodejs/node#49529 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API shape is not great because it's too limited and redundant with the use of
MessagePort.