Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move const variable in node_file.h to node_file.cc #49688

Merged
merged 1 commit into from
Sep 29, 2023
Merged

src: move const variable in node_file.h to node_file.cc #49688

merged 1 commit into from
Sep 29, 2023

Conversation

pluris
Copy link
Contributor

@pluris pluris commented Sep 17, 2023

After checking the comments in the reference, it seems that there is no need to define a 'const' variable in the header.

It seems efficient to handle this by defining it as constexpr in the source file so that it can be evaluated at compile time. For this purpose, it would be better to change it to std::string_view rather than handling it as std::string.

Refs: #48325

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 17, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54008/

This was referenced Sep 18, 2023
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54085/

@anonrig anonrig added the review wanted PRs that need reviews. label Sep 20, 2023
@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Open
22 tasks
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 43500fa into nodejs:main Sep 29, 2023
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 43500fa

@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@alexfernandez
src: move const variable in node_file.h to node_file.cc
28d2e2b 
PR-URL: nodejs#49688
Refs: nodejs#48325
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@pluris pluris deleted the fix/const_variable branch November 8, 2023 02:24
targos pushed a commit that referenced this pull request Nov 11, 2023
@targos
src: move const variable in node_file.h to node_file.cc
ba169be 
PR-URL: #49688
Refs: #48325
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@debadree25
src: move const variable in node_file.h to node_file.cc
c18b114 
PR-URL: nodejs#49688
Refs: nodejs#48325
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pluris @nodejs-github-bot @anonrig @H4ad @aduh95