Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix internalBinding typings #49742

Merged
merged 2 commits into from
Sep 23, 2023
Merged

lib: fix internalBinding typings #49742

merged 2 commits into from
Sep 23, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 20, 2023

I've finally found a way to fix the internalBinding typings for both VSCode and Clion (Intellij).

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 20, 2023 •
edited by GeoffreyBooth
Loading

Review requested:

  • @nodejs/loaders
  • @nodejs/startup
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 20, 2023
GeoffreyBooth
GeoffreyBooth reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, thank you! Can you confirm that this fixes the references to ModuleWrap in the modules code? And/or update those references in this PR?

typings/globals.d.ts Outdated Show resolved Hide resolved
@anonrig @GeoffreyBooth
Update globals.d.ts
6720461 
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
himself65
himself65 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 22, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49742
✔  Done loading data for nodejs/node/pull/49742
----------------------------------- PR info ------------------------------------
Title      lib: fix `internalBinding` typings (#49742)
Author     Yagiz Nizipli  (@anonrig)
Branch     anonrig:internal-binding-2023 -> nodejs:main
Labels     lib / src, author ready, needs-ci, typings, commit-queue-squash
Commits    2
 - lib: fix `internalBinding` typings
 - Update globals.d.ts
Committers 2
 - Yagiz Nizipli 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49742
Reviewed-By: Chemi Atlow 
Reviewed-By: Geoffrey Booth 
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49742
Reviewed-By: Chemi Atlow 
Reviewed-By: Geoffrey Booth 
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 20 Sep 2023 21:55:40 GMT
   ✔  Approvals: 4
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636575033
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636593235
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636652931
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636923558
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6279502512

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54165/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54173/

@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit da7962f into nodejs:main Sep 23, 2023
39 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in da7962f

@github-actions github-actions bot mentioned this pull request Sep 24, 2023
Open
20 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@anonrig @ruyadorno
lib: fix internalBinding typings
efd6815 
PR-URL: #49742
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
Closed
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig @alexfernandez
lib: fix internalBinding typings
6a5fc4e 
PR-URL: nodejs#49742
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@himself65 himself65 himself65 approved these changes

@MoLow MoLow MoLow approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anonrig @nodejs-github-bot @GeoffreyBooth @MoLow @himself65 @Ethan-Arrowood @atlowChemi