-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: remove pthread-fixes.c from uv.gyp #49744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file was removed in the latest libuv upgrade. Remove it from the build recipe as well. Fixes: nodejs#49739
Review requested:
|
nodejs-github-bot
added
libuv
Issues and PRs related to the libuv dependency or the uv binding.
needs-ci
PRs that need a full CI run.
labels
Sep 21, 2023
Closed
RaisinTen
approved these changes
Sep 21, 2023
debadree25
approved these changes
Sep 21, 2023
debadree25
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Sep 21, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 21, 2023
cjihrig
approved these changes
Sep 21, 2023
richardlau
approved these changes
Sep 21, 2023
gengjiawen
approved these changes
Sep 21, 2023
tniessen
approved these changes
Sep 21, 2023
lpinca
approved these changes
Sep 21, 2023
santigimeno
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. Thanks for fixing this
richardlau
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 21, 2023
This was referenced Sep 22, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 23, 2023
Landed in 914ad2f |
20 tasks
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
The file was removed in the latest libuv upgrade. Remove it from the build recipe as well. Fixes: #49739 PR-URL: #49744 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Closed
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
The file was removed in the latest libuv upgrade. Remove it from the build recipe as well. Fixes: nodejs#49739 PR-URL: nodejs#49744 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
richardlau
removed
the
lts-watch-v18.x
PRs that may need to be released in v18.x.
label
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
libuv
Issues and PRs related to the libuv dependency or the uv binding.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file was removed in the latest libuv upgrade. Remove it from the build recipe as well.
Fixes: #49739