-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: improve error performance of chownSync
#49748
Conversation
cc @nodejs/cpp-reviewers |
a67ad16
to
187fb83
Compare
Have you tried typing this function in the REPL and see if the system call happens before you type enter? (perhaps both our REPL and the DevTools console, we use different flags for them) |
86a17b5
to
d1ed9ff
Compare
Force pushed to resolve conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that this is not the right way to change the error throwing behavior. See #49593 (comment)
This needs a rebase |
Closing in favor of #49962 |
Ref: nodejs/performance#106