meta: fix linter error #49755
Merged
meta: fix linter error #49755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
anonrig
approved these changes
Sep 21, 2023
richardlau
approved these changes
Sep 21, 2023
RafaelGSS
approved these changes
Sep 21, 2023
MoLow
approved these changes
Sep 21, 2023
MoLow
added
author ready
benjamingr
approved these changes
Sep 21, 2023
|
Yes please. |
Uzlopak
approved these changes
Sep 21, 2023
mscdex
reviewed
Sep 21, 2023
Comment on lines
42
to
49
| [RaisinTen]: https://github.com/RaisinTen | ||
| [aduh95]: https://github.com/aduh95 | ||
| [benjamingr]: https://github.com/benjamingr | ||
| [jasnell]: https://github.com/jasnell | ||
| [joyeecheung]: https://github.com/joyeecheung | ||
| [legendecas]: https://github.com/legendecas | ||
| [mhdawson]: https://github.com/mhdawson | ||
| [targos]: https://github.com/targos |
There was a problem hiding this comment.
Suggested change
| [RaisinTen]: https://github.com/RaisinTen | |
| [aduh95]: https://github.com/aduh95 | |
| [benjamingr]: https://github.com/benjamingr | |
| [jasnell]: https://github.com/jasnell | |
| [joyeecheung]: https://github.com/joyeecheung | |
| [legendecas]: https://github.com/legendecas | |
| [mhdawson]: https://github.com/mhdawson | |
| [targos]: https://github.com/targos | |
| [aduh95]: https://github.com/aduh95 | |
| [benjamingr]: https://github.com/benjamingr | |
| [jasnell]: https://github.com/jasnell | |
| [joyeecheung]: https://github.com/joyeecheung | |
| [legendecas]: https://github.com/legendecas | |
| [mhdawson]: https://github.com/mhdawson | |
| [RaisinTen]: https://github.com/RaisinTen | |
| [targos]: https://github.com/targos |
?
There was a problem hiding this comment.
Probably upper/lowercase + ascii order?
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9718a94 |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49755 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49755 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #49755 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49755 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49755 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.