Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] test_runner: add shards support #49762

Closed
wants to merge 1 commit into from
Closed

[v18.x backport] test_runner: add shards support #49762

wants to merge 1 commit into from

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented Sep 22, 2023 •
edited
Loading

PR-URL: #48639
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Sep 22, 2023
@rluvaton rluvaton changed the title test_runner: add shards support [v18.x backport] test_runner: add shards support Sep 22, 2023
@rluvaton rluvaton mentioned this pull request Sep 22, 2023
Merged
5 tasks
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54146/

@rluvaton rluvaton force-pushed the backport-48639-to-v18.x branch from 4b06059 to cb8763f Compare September 22, 2023 08:37
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54147/

@rluvaton rluvaton force-pushed the backport-48639-to-v18.x branch from cb8763f to 5e2af43 Compare September 22, 2023 09:02
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54149/

@rluvaton
test_runner: add shards support
4dcd96b 
PR-URL: nodejs#48639
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@rluvaton rluvaton force-pushed the backport-48639-to-v18.x branch from 5e2af43 to 4dcd96b Compare September 22, 2023 10:48
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54150/

This was referenced Sep 23, 2023
Open
Open
@joyeecheung joyeecheung mentioned this pull request Sep 25, 2023
Closed
@targos
Copy link
Member

targos commented Oct 28, 2023

Landed in b55eb2a

@targos targos closed this Oct 28, 2023
targos pushed a commit that referenced this pull request Oct 28, 2023
@rluvaton @targos
test_runner: add shards support
b55eb2a 
PR-URL: #48639
Backport-PR-URL: #49762
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@rluvaton rluvaton deleted the backport-48639-to-v18.x branch October 28, 2023 15:46
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: add shards support
90b7c8d 
PR-URL: nodejs/node#48639
Backport-PR-URL: nodejs/node#49762
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: add shards support
20e3c93 
PR-URL: nodejs/node#48639
Backport-PR-URL: nodejs/node#49762
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rluvaton @nodejs-github-bot @targos