Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openssl 1.0.2f v4.x #4983

Closed
wants to merge 7 commits into from
Closed

Conversation

MylesBorins
Copy link
Contributor

This PR updates openssl to version 1.0.2f on the v4.x LTS argon branch

This is in accordance with the security advisory that was posted in #4857

It was done following the steps documented in https://github.com/TheAlphaNerd/node/blob/f48bce95eea9ad5b15a0872a194fa66623f0e5ba/deps/openssl/doc/UPGRADING.md

Myles Borins and others added 7 commits January 30, 2016 13:32
This replaces all sources of openssl-1.0.2f.tar.gz
into deps/openssl/openssl

PR-URL: nodejs#4961
Reviewed-By:
All symlink files in deps/openssl/openssl/include/openssl/ are removed
and replaced with real header files to avoid issues on Windows.
Two files of opensslconf.h in crypto and include dir are replaced to
refer config/opensslconf.h.

PR-URL: nodejs#4961
Reviewed-By:
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: nodejs#589
PR-URL: nodejs#1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: nodejs#589
PR-URL: nodejs#1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reapply b910613 .

Fixes: nodejs#589
PR-URL: nodejs#1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: nodejs#1461
PR-URL: nodejs#1836
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
the guide is now current with the steps taken to update
openssl to v1.0.2f

PR-URL: nodejs#4961
Reviewed-By:
@MylesBorins
Copy link
Contributor Author

@mscdex mscdex added the openssl Issues and PRs related to the OpenSSL dependency. label Jan 31, 2016
@shigeki
Copy link
Contributor

shigeki commented Jan 31, 2016

Landed in #4961.

@shigeki shigeki closed this Jan 31, 2016
@MylesBorins MylesBorins deleted the openssl-1.0.2f-v4.x branch February 1, 2016 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants