Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix redeclared test-path vars #4991

Closed
wants to merge 1 commit into from
Closed

test: fix redeclared test-path vars #4991

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 31, 2016

No description provided.

@Trott Trott added test Issues and PRs related to the tests. path Issues and PRs related to the path subsystem. lts-watch-v4.x labels Jan 31, 2016
@targos
Copy link
Member

targos commented Jan 31, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

LGTM if CI is green: https://ci.nodejs.org/job/node-test-pull-request/1476/

@r-52
Copy link
Contributor

r-52 commented Feb 1, 2016

LGTM

1 similar comment
@jbergstroem
Copy link
Member

LGTM

jasnell pushed a commit that referenced this pull request Feb 2, 2016
@Trott @jasnell
test: fix redeclared test-path vars
352173b 
PR-URL: #4991
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 2, 2016

Landed in 352173b

@jasnell jasnell closed this Feb 2, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@Trott @rvagg
test: fix redeclared test-path vars
51fb884 
PR-URL: #4991
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
test: fix redeclared test-path vars
36625f3 
PR-URL: #4991
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
test: fix redeclared test-path vars
58595f1 
PR-URL: #4991
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@Trott
test: fix redeclared test-path vars
6c2d902 
PR-URL: #4991
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: fix redeclared test-path vars
88c07a3 
PR-URL: nodejs#4991
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the test-path-no-redeclare branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
path Issues and PRs related to the path subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @targos @jasnell @r-52 @jbergstroem @MylesBorins