src: limit Buffer::kMaxLength to 1TB #49930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs#49876 Refs: nodejs/node-v8#268
nodejs-github-bot
added
buffer
anonrig
reviewed
Sep 28, 2023
bnoordhuis
approved these changes
Sep 28, 2023
anonrig
approved these changes
Sep 30, 2023
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
|
I had to push a fixup commit, because |
bnoordhuis
approved these changes
Sep 30, 2023
github-actions
bot
removed
the
request-ci
This was referenced Oct 1, 2023
|
Converted to draft because the issue with ASAN isn't fixed by this and while reducing the limit further would be enough, canary builds show other issues related to this change: nodejs/node-v8#268 (comment) |
targos
removed
the
author ready
This was referenced Oct 3, 2023
|
Will revisit this in the V8 11.9 update PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has no real effect for now, as the V8 maximum typed array
length is still
2**32. When V8 is updated to version 11.9 or later, thelimit will be
2**53-1on 64-bit architectures, much larger than anyreasonable amount of RAM. This caps the limit at 1TB, which is already
very large and corresponds to the maximum memory that AddressSanitizer
allows to allocate.
Refs: #49876
Refs: nodejs/node-v8#268