Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve code coverage of diagnostics_channel #50053

Conversation

MrJithil
Copy link
Member

@MrJithil MrJithil commented Oct 5, 2023

test: improve code coverage of diagnostics_channel

Screenshot 2023-10-06 at 12 51 32 am

Current coverage report: https://app.codecov.io/gh/nodejs/node/blob/main/lib%2Fdiagnostics_channel.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 5, 2023
@MrJithil MrJithil force-pushed the code-coverage-improvement-diagnostics_channel branch 4 times, most recently from 3789b15 to 316f34a Compare October 5, 2023 23:51
@MrJithil MrJithil marked this pull request as draft October 6, 2023 04:44
@MrJithil MrJithil closed this Oct 7, 2023
@MrJithil MrJithil reopened this Oct 7, 2023
@MrJithil MrJithil force-pushed the code-coverage-improvement-diagnostics_channel branch from 316f34a to f23b7d2 Compare October 7, 2023 08:01
@MrJithil MrJithil marked this pull request as ready for review October 7, 2023 08:01
@Flarna Flarna added diagnostics_channel Issues and PRs related to diagnostics channel request-ci Add this label to start a Jenkins CI on a PR. labels Oct 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023
@nodejs-github-bot

This comment was marked as outdated.

test: improve code coverage of diagnostics_channel
@MrJithil MrJithil force-pushed the code-coverage-improvement-diagnostics_channel branch from f23b7d2 to a5b62f8 Compare October 10, 2023 12:49
@MrJithil
Copy link
Member Author

@Flarna Please review.

@MrJithil MrJithil requested a review from Flarna October 10, 2023 12:54
@nodejs-github-bot

This comment was marked as outdated.

@Flarna Flarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2023
@MrJithil
Copy link
Member Author

@Flarna please help to re run the C I.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54846/

@Flarna Flarna added review wanted PRs that need reviews. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 16, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit a8af24b into nodejs:main Oct 19, 2023
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a8af24b

@Flarna Flarna removed the review wanted PRs that need reviews. label Oct 19, 2023
targos pushed a commit that referenced this pull request Oct 23, 2023
test: improve code coverage of diagnostics_channel
PR-URL: #50053
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
test: improve code coverage of diagnostics_channel
PR-URL: nodejs#50053
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos pushed a commit that referenced this pull request Nov 11, 2023
test: improve code coverage of diagnostics_channel
PR-URL: #50053
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. diagnostics_channel Issues and PRs related to diagnostics channel needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants