Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify optional arguments of Buffer methods #5008

Closed
wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jan 31, 2016

doc: clarify optional arguments of Buffer methods

@targos targos added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. lts-watch-v4.x labels Jan 31, 2016
@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

LGTM

@Qard
Copy link
Member

Qard commented Feb 2, 2016

Does our json docs tooling understand this format?

@jasnell
Copy link
Member

jasnell commented Feb 2, 2016

It should, this pattern is used elsewhere in the docs.

@Qard
Copy link
Member

Qard commented Feb 2, 2016

LGTM then.

targos added a commit that referenced this pull request Feb 3, 2016
PR-URL: #5008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@targos
Copy link
Member Author

targos commented Feb 3, 2016

Thanks. Landed in 4501a28

@targos targos closed this Feb 3, 2016
@targos targos deleted the doc-buffer-fill branch February 3, 2016 18:56
rvagg pushed a commit that referenced this pull request Feb 8, 2016
PR-URL: #5008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
PR-URL: #5008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
PR-URL: #5008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #5008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#5008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants