stream: add support for `deflate-raw` format to webstreams compression #50097

pirxpilot · 2023-10-09T06:47:49Z

this change makes deflate-raw a valid parameter for both CompressionStream and DecompressionStream constructors

it makes node's implementation consistent with what modern browsers support and what specification calls for

see: https://wicg.github.io/compression/#compression-stream

Edit: Notable Change

doc/api/webstreams.md

github-actions · 2023-10-09T11:54:18Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment.

Edit: Notable Change

this change makes `deflate-raw` a valid parameter for both CompressionStream and DecompressionStream constructors it makes node's implementation consistent with what modern browsers support and what specification calls for see: https://wicg.github.io/compression/#compression-stream

needed until nodejs/node#50097 is released

nodejs-github-bot · 2023-10-31T06:01:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55340/

nodejs-github-bot · 2023-11-09T10:25:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55516/

panva · 2023-11-09T10:30:01Z

Notable change text proposal:

The "deflate-raw" compression format was added to the CompressionStream and DecompressionStream APIs. This format has been recently added to other JS runtimes and its inclusion in Node.js improves interoperability of the API with these runtimes.

panva · 2023-11-09T11:18:53Z

@pirxpilot Thank you for working on this, amazing first contribution!

nodejs-github-bot · 2023-11-09T11:18:59Z

Landed in 3e14cfb

panva · 2023-11-09T11:22:40Z

I've opened a followup, #50631, to enable the compression WPTs and fix the constructor handling of the format argument to follow its WebIDL definition. For the rest I'll open an issue to document the other failing or skipped WPTs so that they may also be looked at by someone with deeper knowledge of the subsystem.

this change makes `deflate-raw` a valid parameter for both CompressionStream and DecompressionStream constructors it makes node's implementation consistent with what modern browsers support and what specification calls for see: https://wicg.github.io/compression/#compression-stream PR-URL: #50097 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Notable changes: doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib: * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385 stream: * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097 * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: #50681

Notable changes: doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib: * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562 * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303 * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385 stream: * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097 * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: #50681

this change makes `deflate-raw` a valid parameter for both CompressionStream and DecompressionStream constructors it makes node's implementation consistent with what modern browsers support and what specification calls for see: https://wicg.github.io/compression/#compression-stream PR-URL: #50097 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Notable changes: doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib: * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562 * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303 * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385 stream: * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097 * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: #50681

Notable changes: doc: * add MrJithil to collaborators (Jithil P Ponnan) nodejs#50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) nodejs#50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) nodejs#48740 fs: * add stacktrace to fs/promises (翠 / green) nodejs#49849 lib: * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) nodejs#50562 * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) nodejs#50303 * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) nodejs#50385 stream: * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) nodejs#50097 * use Array for Readable buffer (Robert Nagy) nodejs#50341 * optimize creation (Robert Nagy) nodejs#50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) nodejs#50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) nodejs#48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) nodejs#50443 PR-URL: nodejs#50681

this change makes `deflate-raw` a valid parameter for both CompressionStream and DecompressionStream constructors it makes node's implementation consistent with what modern browsers support and what specification calls for see: https://wicg.github.io/compression/#compression-stream PR-URL: #50097 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Oct 9, 2023

anonrig added the notable-change PRs with changes that should be highlighted in changelogs. label Oct 9, 2023

anonrig reviewed Oct 9, 2023

View reviewed changes

doc/api/webstreams.md Show resolved Hide resolved

doc/api/webstreams.md Show resolved Hide resolved

pirxpilot force-pushed the add-deflate-raw-support branch from 80e9be3 to 86a5c7f Compare October 9, 2023 12:39

anonrig approved these changes Oct 9, 2023

View reviewed changes

pirxpilot force-pushed the add-deflate-raw-support branch from 86a5c7f to 0331b7a Compare October 9, 2023 13:04

tniessen requested a review from jasnell October 9, 2023 13:33

tniessen approved these changes Oct 9, 2023

View reviewed changes

lpinca approved these changes Oct 9, 2023

View reviewed changes

pirxpilot added a commit to furkot/import-kmz that referenced this pull request Oct 10, 2023

test naive polyfill for webstream deflate-raw

6663ff9

needed until nodejs/node#50097 is released

wojpawlik mentioned this pull request Oct 15, 2023

streaming support greggman/unzipit#32

Open

anonrig approved these changes Oct 20, 2023

View reviewed changes

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2023

This comment was marked as outdated.

Sign in to view

This was referenced Oct 22, 2023

CI Reliability 2023-10-22 nodejs/reliability#694

Open

CI Reliability 2023-10-23 nodejs/reliability#695

Open

CI Reliability 2023-10-24 nodejs/reliability#696

Open

jasnell approved these changes Oct 28, 2023

View reviewed changes

This was referenced Nov 1, 2023

CI Reliability 2023-11-01 nodejs/reliability#704

Open

CI Reliability 2023-11-02 nodejs/reliability#705

Open

CI Reliability 2023-11-03 nodejs/reliability#706

Open

panva mentioned this pull request Nov 9, 2023

test,stream: enable compression WPTs #50631

Closed

panva added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 9, 2023

panva added the stream Issues and PRs related to the stream subsystem. label Nov 9, 2023

panva approved these changes Nov 9, 2023

View reviewed changes

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2023

nodejs-github-bot merged commit 3e14cfb into nodejs:main Nov 9, 2023
60 checks passed

targos mentioned this pull request Nov 12, 2023

v21.2.0 release proposal #50681

Merged

panva mentioned this pull request Dec 15, 2023

stream: WPT fixes for Compression Streams #50712

Closed

richardlau mentioned this pull request Mar 25, 2024

v20.12.0 proposal #52212

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stream: add support for `deflate-raw` format to webstreams compression #50097

stream: add support for `deflate-raw` format to webstreams compression #50097

pirxpilot commented Oct 9, 2023 •

edited by panva

Loading

github-actions bot commented Oct 9, 2023 •

edited by panva

Loading

This comment was marked as outdated.

nodejs-github-bot commented Oct 31, 2023

nodejs-github-bot commented Nov 9, 2023

panva commented Nov 9, 2023 •

edited

Loading

panva commented Nov 9, 2023

nodejs-github-bot commented Nov 9, 2023

panva commented Nov 9, 2023 •

edited

Loading

stream: add support for deflate-raw format to webstreams compression #50097

stream: add support for deflate-raw format to webstreams compression #50097

Conversation

pirxpilot commented Oct 9, 2023 • edited by panva Loading

github-actions bot commented Oct 9, 2023 • edited by panva Loading

This comment was marked as outdated.

nodejs-github-bot commented Oct 31, 2023

nodejs-github-bot commented Nov 9, 2023

panva commented Nov 9, 2023 • edited Loading

panva commented Nov 9, 2023

nodejs-github-bot commented Nov 9, 2023

panva commented Nov 9, 2023 • edited Loading

stream: add support for `deflate-raw` format to webstreams compression #50097

stream: add support for `deflate-raw` format to webstreams compression #50097

pirxpilot commented Oct 9, 2023 •

edited by panva

Loading

github-actions bot commented Oct 9, 2023 •

edited by panva

Loading

panva commented Nov 9, 2023 •

edited

Loading

panva commented Nov 9, 2023 •

edited

Loading