typings: lib/internal/vm.js #50112
Merged
typings: lib/internal/vm.js #50112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffreyBooth
force-pushed
the
type-internal-compile-function
branch
from
1999445
to
a280623
Compare
anonrig
approved these changes
Oct 10, 2023
GeoffreyBooth
added
the
author ready
joyeecheung
reviewed
Oct 12, 2023
|
This needs a rebase |
aduh95
removed
the
author ready
legendecas
reviewed
Dec 11, 2023
|
@GeoffreyBooth thanks so much for opening a PR! To be honest, I don't think the doc annotation adds much in this case given they're just a long form of the variable/function names. Would it be OK if we close this without merging it? Thanks for understanding. |
The main thing it adds is hinting for the types of arguments in your editor as you work. This was waiting on another PR from @joyeecheung but it might be unblocked now. I'm not sure when I'll have time to rebase but anyone else can finish this. |
GeoffreyBooth
force-pushed
the
type-internal-compile-function
branch
from
a280623
to
c9ca65c
Compare
anonrig
approved these changes
Feb 4, 2024
legendecas
reviewed
Feb 4, 2024
joyeecheung
reviewed
Feb 5, 2024
legendecas
approved these changes
Feb 5, 2024
Thanks, that looks like it fixed the lint check, if you don’t mind reapproving. |
fhinkel
approved these changes
Feb 5, 2024
Gotcha! Thanks for following up. LGTM. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50112 ✔ Done loading data for nodejs/node/pull/50112 ----------------------------------- PR info ------------------------------------ Title typings: lib/internal/vm.js (#50112) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch GeoffreyBooth:type-internal-compile-function -> nodejs:main Labels vm, author ready, typings, commit-queue-squash Commits 7 - typings: lib/internal/vm.js - @legendecas suggestion - lint - Apply suggestions from code review - Update lib/internal/vm.js - Apply suggestions from code review - Apply suggestions from code review Committers 2 - Geoffrey Booth - GitHub PR-URL: https://github.com/nodejs/node/pull/50112 Reviewed-By: Yagiz Nizipli Reviewed-By: Chengzhong Wu Reviewed-By: Franziska Hinkelmann Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50112 Reviewed-By: Yagiz Nizipli Reviewed-By: Chengzhong Wu Reviewed-By: Franziska Hinkelmann Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 10 Oct 2023 03:48:21 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1861179506 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864665265 ✔ - Franziska Hinkelmann (@fhinkel): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864005359 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1865292289 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7815976165 |
legendecas
added
request-ci
github-actions
bot
removed
the
request-ci
GeoffreyBooth
force-pushed
the
type-internal-compile-function
branch
from
dfdf6a7
to
2550c46
Compare
GeoffreyBooth
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50112 ✔ Done loading data for nodejs/node/pull/50112 ----------------------------------- PR info ------------------------------------ Title typings: lib/internal/vm.js (#50112) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch GeoffreyBooth:type-internal-compile-function -> nodejs:main Labels vm, author ready, typings, commit-queue-squash Commits 3 - typings: lib/internal/vm.js - @legendecas suggestion - lint Committers 1 - Geoffrey Booth PR-URL: https://github.com/nodejs/node/pull/50112 Reviewed-By: Yagiz Nizipli Reviewed-By: Chengzhong Wu Reviewed-By: Franziska Hinkelmann Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50112 Reviewed-By: Yagiz Nizipli Reviewed-By: Chengzhong Wu Reviewed-By: Franziska Hinkelmann Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - typings: lib/internal/vm.js ⚠ - @legendecas suggestion ⚠ - lint ℹ This PR was created on Tue, 10 Oct 2023 03:48:21 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1861179506 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864665265 ✔ - Franziska Hinkelmann (@fhinkel): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864005359 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1865292289 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-02-17T23:55:37Z: https://ci.nodejs.org/job/node-test-pull-request/57165/ - Querying data for job/node-test-pull-request/57165/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7949622474 |
|
Can someone please reapprove this so it can land? |
Trott
approved these changes
Feb 18, 2024
GeoffreyBooth
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0550bc1 |
targos
pushed a commit
that referenced
this pull request
Feb 19, 2024
PR-URL: #50112 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 20, 2024
PR-URL: nodejs#50112 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50112 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50112 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny PR to add a little JSDoc.