Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix H4ad collaborator sort #50218

Merged
merged 1 commit into from
Oct 17, 2023
Merged

doc: fix H4ad collaborator sort #50218

merged 1 commit into from
Oct 17, 2023

Conversation

H4ad
Copy link
Member

@H4ad H4ad commented Oct 17, 2023

@H4ad H4ad requested review from anonrig and aduh95 October 17, 2023 19:23
@H4ad H4ad self-assigned this Oct 17, 2023
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 17, 2023
@MoLow MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 17, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

KhafraDev
KhafraDev approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

congrats!

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6dadb99 into nodejs:main Oct 17, 2023
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6dadb99

@H4ad H4ad deleted the doc/fix-collaborators-sort branch October 17, 2023 19:32
targos pushed a commit that referenced this pull request Oct 23, 2023
@H4ad @targos
doc: fix H4ad collaborator sort
8c1a46c 
PR-URL: #50218
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@H4ad @alexfernandez
doc: fix H4ad collaborator sort
7eb7754 
PR-URL: nodejs#50218
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@H4ad @targos
doc: fix H4ad collaborator sort
f37b577 
PR-URL: #50218
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhafraDev KhafraDev KhafraDev approved these changes

@MoLow MoLow MoLow approved these changes

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees

@H4ad H4ad

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@H4ad @nodejs-github-bot @anonrig @richardlau @MoLow @KhafraDev