Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-loaders-workers-spawned flakiness #50251

Merged
merged 1 commit into from
Oct 19, 2023
Merged

test: fix test-loaders-workers-spawned flakiness #50251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/es-module/test-loaders-workers-spawned.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,14 @@ describe('Worker threads do not spawn infinitely', { concurrency: true }, () =>
]);

assert.strictEqual(stderr, '');
// We are validating that:
// 1. the `--require` flag is run first from the main thread (and A is printed).
// 2. the `--require` flag is then run on the loader thread (and A is printed).
// 3. the `--loader` module is executed (and B is printed).
// 4. the `--import` module is evaluated once, on the main thread (and C is printed).
// 5. the user code is finally executed (and D is printed).
// The worker code should always run before the --import, but the console.log might arrive late.
assert.match(stdout, /^A\r?\nA\r?\n(B\r?\nC|C\r?\nB)\r?\nD\r?\n$/);
assert.match(stdout, /^A\r?\n(A\r?\nB\r?\nC|A\r?\nC\r?\nB|C\r?\nA\r?\nB)\r?\nD\r?\n$/);
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
});
Expand Down