Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 11.8.172.17 #50292

Merged
merged 1 commit into from
Oct 31, 2023
Merged

deps: patch V8 to 11.8.172.17 #50292

merged 1 commit into from
Oct 31, 2023

Conversation

targos
Copy link
Member

@targos targos commented Oct 19, 2023

@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Oct 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 19, 2023
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55009/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5622/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5622/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5622/

This was referenced Oct 20, 2023
Open
Open
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55136/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5627/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5627/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5627/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55146/

This was referenced Oct 24, 2023
Open
Open
Open
@targos targos changed the title deps: patch V8 to 11.8.172.16 deps: patch V8 to 11.8.172.17 Oct 28, 2023
@targos
Copy link
Member Author

targos commented Oct 28, 2023

Rebased and updated patch to 11.8.172.17.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55286/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5637/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5637/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5637/

@targos
Copy link
Member Author

targos commented Oct 31, 2023

CI looks good. Can someone review the latest commit?

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0899bee into nodejs:main Oct 31, 2023
23 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0899bee

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@targos @alexfernandez
deps: patch V8 to 11.8.172.17
b866343 
Refs: v8/v8@11.8.172.15...11.8.172.17
PR-URL: nodejs#50292
Refs: v8/v8@11.8.172.15...11.8.172.16
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
@targos @anonrig
deps: patch V8 to 11.8.172.17
a79a0fe 
Refs: v8/v8@11.8.172.15...11.8.172.17
PR-URL: nodejs#50292
Refs: v8/v8@11.8.172.15...11.8.172.16
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos added a commit that referenced this pull request Nov 11, 2023
@targos
deps: patch V8 to 11.8.172.17
03bd32f 
Refs: v8/v8@11.8.172.15...11.8.172.17
PR-URL: #50292
Refs: v8/v8@11.8.172.15...11.8.172.16
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos added a commit that referenced this pull request Nov 14, 2023
@targos
deps: patch V8 to 11.8.172.17
1e6922e 
Refs: v8/v8@11.8.172.15...11.8.172.17
PR-URL: #50292
Refs: v8/v8@11.8.172.15...11.8.172.16
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @nodejs-github-bot @gengjiawen @richardlau