Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set inspector-wait-for-connection as flaky #50294

Closed
wants to merge 1 commit into from
Closed

test: set inspector-wait-for-connection as flaky #50294

wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 19, 2023 •
edited
Loading

Ref: #50293

cc @nodejs/platform-macos @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 19, 2023
@anonrig anonrig added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 19, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55012/

@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55053/

This was referenced Oct 21, 2023
Open
Open
@H4ad H4ad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55123/

@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55243/

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55244/

This was referenced Oct 27, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55294/

This was referenced Oct 29, 2023
Open
Open
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Nov 29, 2023
@aduh95 aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023
@aduh95
Copy link
Contributor

aduh95 commented Nov 29, 2023

This needs a rebase

@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2023
@avivkeller
Copy link
Member

Hi! It's been a while since any activity on this PR, but it has several approvals. This comment will bump this issue to the front of the PR page so more people can see (and implement) this change.

If you still want to pursue this, please ensure this change is relevant.

This comment is an attempt to resolve older pull requests.

@targos
Copy link
Member

targos commented Apr 23, 2024

Closing as the referenced issue is marked as fixed.

@targos targos closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cola119 cola119 cola119 approved these changes

@H4ad H4ad H4ad approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@anonrig @nodejs-github-bot @aduh95 @avivkeller @targos @jasnell @H4ad @cola119