Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick f7d000a7ae7b #50302

Merged
merged 1 commit into from
Oct 23, 2023

Commits on Oct 20, 2023

  1. deps: V8: cherry-pick f7d000a7ae7b

    Original commit message:
    
        [logging] Bugfix: LinuxPerfBasicLogger should log JS functions
    
        This patch fixes a typo that was introduced in commit
        c51041f45400928cd64fbc8f389c0dd0dd15f82f /
        https://chromium-review.googlesource.com/c/v8/v8/+/2336793, which reversed the behavior of the perf_basic_prof_only_functions flag.
    
        This also refactors the equivalent guard in LinuxPerfJitLogger to use the same inline CodeKind API for identifying JS Functions. This is unrelated to the bug, but it seems a fair rider to add on here.
    
        Bug: v8:14387
        Change-Id: I25766b0d45f4c65dfec5ae01e094a1ed94111054
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4954225
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Commit-Queue: Camillo Bruni <cbruni@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#90501}
    
    Refs: v8/v8@f7d000a
    lukealbao committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8254883 View commit details
    Browse the repository at this point in the history