-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Replace forEach() with for ... of #50608
Conversation
@alexweej Thank you for the contribution. Your commit email address does not appear to be associated with your GitHub account. We highly recommend fixing this, either by adding your commit email address to your GitHub account, or by re-committing using a different email address and force-pushing to the same branch (and PR). Also, the commit message does not match the commit message guidelines. It needs to start with the prefix |
That'll teach me to use my work laptop... |
f019481
to
f9fd61c
Compare
@tniessen does the project prefer that we iterate on a single commit in each PR? As in, you need me to update both the PR title and the underlying commit title? Thanks again |
f9fd61c
to
753aae0
Compare
@alexweej We generally prefer pushing additional commits to update existing PRs, except when it comes to the commit message. The commit message of the first commit must adhere to the style guide, which is why that check is still failing on this PR. It is complaining that On a side note, neither the git commit author nor the committer are associated with your GitHub account. We recommend fixing this, but it is not required. |
Replace `Array.prototype.forEach()` with `for...of` in `parallel/test-whatwg-encoding-custom-textdecoder-utf16-surrogates.js`. PR-URL: #50608 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 55f3993. |
Replace `Array.prototype.forEach()` with `for...of` in `parallel/test-whatwg-encoding-custom-textdecoder-utf16-surrogates.js`. PR-URL: #50608 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Replace `Array.prototype.forEach()` with `for...of` in `parallel/test-whatwg-encoding-custom-textdecoder-utf16-surrogates.js`. PR-URL: #50608 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Replace `Array.prototype.forEach()` with `for...of` in `parallel/test-whatwg-encoding-custom-textdecoder-utf16-surrogates.js`. PR-URL: #50608 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
From https://docs.google.com/spreadsheets/d/1mqLZafbDSI_2h6hijO4IYxoibjayzHYt__ZMbVc1s2A/edit#gid=0