deps: update base64 to 0.5.1 #50629

nodejs-github-bot · 2023-11-08T19:48:53Z

This is an automated update of base64 to 0.5.1.

nodejs-github-bot · 2023-11-08T20:22:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55504/

lpinca · 2023-11-08T20:25:10Z

2023-11-08T20:20:03.7087248Z      Creating library out\Release\node_mksnapshot.lib and object out\Release\node_mksnapshot.exp
2023-11-08T20:20:04.7094937Z base64.lib(codec_choose.obj) : error LNK2019: unresolved external symbol base64_stream_encode_avx512 referenced in function codec_choose [D:\a\node\node\node_mksnapshot.vcxproj]
2023-11-08T20:20:04.8149299Z base64.lib(codec_choose.obj) : error LNK2019: unresolved external symbol base64_stream_decode_avx512 referenced in function codec_choose [D:\a\node\node\node_mksnapshot.vcxproj]
2023-11-08T20:20:04.8334738Z out\Release\node_mksnapshot.exe : fatal error LNK1120: 2 unresolved externals [D:\a\node\node\node_mksnapshot.vcxproj]
2023-11-08T20:20:05.2746557Z ##[error]Process completed with exit code 1.

richardlau · 2023-11-08T20:30:57Z

2023-11-08T20:20:03.7087248Z      Creating library out\Release\node_mksnapshot.lib and object out\Release\node_mksnapshot.exp
2023-11-08T20:20:04.7094937Z base64.lib(codec_choose.obj) : error LNK2019: unresolved external symbol base64_stream_encode_avx512 referenced in function codec_choose [D:\a\node\node\node_mksnapshot.vcxproj]
2023-11-08T20:20:04.8149299Z base64.lib(codec_choose.obj) : error LNK2019: unresolved external symbol base64_stream_decode_avx512 referenced in function codec_choose [D:\a\node\node\node_mksnapshot.vcxproj]
2023-11-08T20:20:04.8334738Z out\Release\node_mksnapshot.exe : fatal error LNK1120: 2 unresolved externals [D:\a\node\node\node_mksnapshot.vcxproj]
2023-11-08T20:20:05.2746557Z ##[error]Process completed with exit code 1.

deps/base64/base64.gyp will need updates to add the new files.

lpinca · 2023-11-08T20:32:41Z

Yes, we can cherry-pick @lucshi's changes here https://github.com/nodejs/node/pull/45091/files.

Update the Base64 SIMD library which include new features of AVX512 support and AVX inline assembly and several bug fixes. Fixes: #45089

nodejs-github-bot · 2023-11-08T21:08:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55505/

lpinca

RSLGTM

nodejs-github-bot · 2023-11-09T06:40:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55510/

Uzlopak

LGTM

nodejs-github-bot · 2023-11-10T19:54:34Z

Commit Queue failed

- Loading data for nodejs/node/pull/50629 ✔ Done loading data for nodejs/node/pull/50629 ----------------------------------- PR info ------------------------------------ Title deps: update base64 to 0.5.1 (#50629) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-base64 -> nodejs:main Labels needs-ci, dependencies, commit-queue-squash Commits 2 - deps: update base64 to 0.5.1 - deps: update Base64 SIMD library Committers 2 - Node.js GitHub Bot - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/50629 Fixes: https://github.com/nodejs/node/issues/50561 Fixes: https://github.com/nodejs/node/pull/45091 Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Yagiz Nizipli Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50629 Fixes: https://github.com/nodejs/node/issues/50561 Fixes: https://github.com/nodejs/node/pull/45091 Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Yagiz Nizipli Reviewed-By: Richard Lau -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 08 Nov 2023 19:48:53 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50629#pullrequestreview-1721292055 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/50629#pullrequestreview-1721919876 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50629#pullrequestreview-1723745060 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/50629#pullrequestreview-1723844047 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-11-09T06:40:19Z: https://ci.nodejs.org/job/node-test-pull-request/55510/ - Querying data for job/node-test-pull-request/55510/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50629 From https://github.com/nodejs/node * branch refs/pull/50629/merge -> FETCH_HEAD ✔ Fetched commits as 3c5eb43cadca..fcfcbffdd208 -------------------------------------------------------------------------------- [main f63d052202] deps: update base64 to 0.5.1 Date: Wed Nov 8 19:48:51 2023 +0000 31 files changed, 1660 insertions(+), 138 deletions(-) create mode 100644 deps/base64/base64/lib/arch/avx/enc_loop_asm.c create mode 100644 deps/base64/base64/lib/arch/avx2/enc_loop_asm.c create mode 100644 deps/base64/base64/lib/arch/avx512/codec.c create mode 100644 deps/base64/base64/lib/arch/avx512/enc_loop.c create mode 100644 deps/base64/base64/lib/arch/avx512/enc_reshuffle_translate.c create mode 100644 deps/base64/base64/lib/arch/ssse3/enc_loop_asm.c create mode 100755 deps/base64/base64/test/ci/analysis.sh [main 9e648ed7a2] deps: update Base64 SIMD library Author: lucshi Date: Thu Oct 20 21:22:56 2022 +0800 1 file changed, 27 insertions(+) ✔ Patches applied There are 2 commits in the PR. Attempting to fixup everything into first commit. [main d7bbafa58d] deps: update base64 to 0.5.1 Date: Wed Nov 8 19:48:51 2023 +0000 32 files changed, 1687 insertions(+), 138 deletions(-) create mode 100644 deps/base64/base64/lib/arch/avx/enc_loop_asm.c create mode 100644 deps/base64/base64/lib/arch/avx2/enc_loop_asm.c create mode 100644 deps/base64/base64/lib/arch/avx512/codec.c create mode 100644 deps/base64/base64/lib/arch/avx512/enc_loop.c create mode 100644 deps/base64/base64/lib/arch/avx512/enc_reshuffle_translate.c create mode 100644 deps/base64/base64/lib/arch/ssse3/enc_loop_asm.c create mode 100755 deps/base64/base64/test/ci/analysis.sh --------------------------------- New Message ---------------------------------- deps: update base64 to 0.5.1

PR-URL: #50629
Fixes: #50561
Fixes: #45091
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Richard Lau rlau@redhat.com

[main a80acbb020] deps: update base64 to 0.5.1
Date: Wed Nov 8 19:48:51 2023 +0000
32 files changed, 1687 insertions(+), 138 deletions(-)
create mode 100644 deps/base64/base64/lib/arch/avx/enc_loop_asm.c
create mode 100644 deps/base64/base64/lib/arch/avx2/enc_loop_asm.c
create mode 100644 deps/base64/base64/lib/arch/avx512/codec.c
create mode 100644 deps/base64/base64/lib/arch/avx512/enc_loop.c
create mode 100644 deps/base64/base64/lib/arch/avx512/enc_reshuffle_translate.c
create mode 100644 deps/base64/base64/lib/arch/ssse3/enc_loop_asm.c
create mode 100755 deps/base64/base64/test/ci/analysis.sh
✖ a80acbb020d393131e323750e126bb81df89dc0d
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 2:7 Valid fixes URL. fixes-url
✖ 3:7 Pull request URL must reference a comment or discussion. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/6829043038

lpinca · 2023-11-11T06:27:32Z

Landed in f45bb80.

PR-URL: #50629 Fixes: #50561 Fixes: #45091 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>

nodejs/node#50629

* chore: bump node in DEPS to v20.11.0 * module: bootstrap module loaders in shadow realm nodejs/node#48655 * src: add commit hash shorthand in zlib version nodejs/node#50158 * v8,tools: expose necessary V8 defines nodejs/node#50820 * esm: do not call getSource when format is commonjs nodejs/node#50465 * esm: fallback to readFileSync when source is nullish nodejs/node#50825 * vm: allow dynamic import with a referrer realm nodejs/node#50360 * test: skip test-diagnostics-channel-memory-leak.js nodejs/node#50327 * esm: do not call getSource when format is commonjs nodejs/node#50465 * lib: fix assert throwing different error messages in ESM and CJS nodejs/node#50634 * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * deps: update base64 to 0.5.1 nodejs/node#50629 * src: avoid silent coercion to signed/unsigned int nodejs/node#50663 * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * chore: fix patch indices * chore: update patches * test: disable TLS cipher test This can't be enabled owing to BoringSSL incompatibilities. nodejs/node#50186 * fix: check for Buffer and global definition in shadow realm nodejs/node#51239 * test: disable parallel/test-shadow-realm-custom-loader Incompatible with our asar logic, resulting in the following failure: > Failed to CompileAndCall electron script: electron/js2c/asar_bundle * chore: remove deleted parallel/test-crypto-modp1-error test * test: make test-node-output-v8-warning generic nodejs/node#50421 * chore: fixup ModuleWrap patch * test: match wpt/streams/transferable/transform-stream-members.any.js to upstream * fix: sandbox is not enabled on arm * chore: disable v8 sandbox on ia32/arm --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Cheng Zhao <zcbenz@gmail.com>

PR-URL: #50629 Fixes: #50561 Fixes: #45091 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `18.19.1` -> `18.20.0` | --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v18.20.0`](https://github.com/nodejs/node/releases/tag/v18.20.0): 2024-03-26, Version 18.20.0 'Hydrogen' (LTS), @richardlau [Compare Source](nodejs/node@v18.19.1...v18.20.0) ##### Notable Changes ##### Added support for import attributes Support has been added for import attributes, to replace the old import assertions syntax. This will aid migration by making the new syntax available across all currently supported Node.js release lines. This adds the `with` keyword which should be used in place of the previous `assert` keyword, which will be removed in a future semver-major Node.js release. For example, ```console import "foo" assert { ... } ``` should be replaced with ```console import "foo" with { ... } ``` For more details, see - [#50134](nodejs/node#50134) - [#51622](nodejs/node#51622) Contributed by Nicolò Ribaudo in [#51136](nodejs/node#51136) and Antoine du Hamel in [#50140](nodejs/node#50140). ##### Doc deprecation for `dirent.path` Please use newly added `dirent.parentPath` instead. Contributed by Antoine du Hamel in [#50976](nodejs/node#50976) and [#51020](nodejs/node#51020). ##### Experimental node-api feature flags Introduces an experimental feature to segregate finalizers that affect GC state. A new type called `node_api_nogc_env` has been introduced as the const version of `napi_env` and `node_api_nogc_finalize` as a variant of `napi_finalize` that accepts a `node_api_nogc_env` as its first argument. This feature can be turned off by defining `NODE_API_EXPERIMENTAL_NOGC_ENV_OPT_OUT`. Contributed by Gabriel Schulhof in [#50060](nodejs/node#50060). ##### Root certificates updated to NSS 3.98 Certificates added: - Telekom Security TLS ECC Root 2020 - Telekom Security TLS RSA Root 2023 Certificates removed: - Security Communication Root CA ##### Updated dependencies - ada updated to 2.7.6. - base64 updated to 0.5.2. - c-ares updated to 1.27.0. - corepack updated to 0.25.2. - ICU updated to 74.2. Includes CLDR 44.1 and Unicode 15.1. - npm updated to 10.5.0. Fixes a regression in signals not being passed onto child processes. - simdutf8 updated to 4.0.8. - Timezone updated to 2024a. - zlib updated to 1.3.0.1-motley-40e35a7. ##### vm: fix V8 compilation cache support for vm.Script Previously repeated compilation of the same source code using `vm.Script` stopped hitting the V8 compilation cache after v16.x when support for `importModuleDynamically` was added to `vm.Script`, resulting in a performance regression that blocked users (in particular Jest users) from upgrading from v16.x. The recent fixes allow the compilation cache to be hit again for `vm.Script` when `--experimental-vm-modules` is not used even in the presence of the `importModuleDynamically` option, so that users affected by the performance regression can now upgrade. Ongoing work is also being done to enable compilation cache support for `vm.CompileFunction`. Contributed by Joyee Cheung in [#49950](nodejs/node#49950) and [#50137](nodejs/node#50137). ##### Commits - \[[`c70383b8d4`](nodejs/node@c70383b8d4)] - **build**: support Python 3.12 (Shi Pujin) [#50209](nodejs/node#50209) - \[[`4b960c3a4a`](nodejs/node@4b960c3a4a)] - **build**: fix incorrect g++ warning message (Richard Lau) [#51695](nodejs/node#51695) - \[[`8fdea67694`](nodejs/node@8fdea67694)] - **crypto**: update root certificates to NSS 3.98 (Node.js GitHub Bot) [#51794](nodejs/node#51794) - \[[`812b126dd9`](nodejs/node@812b126dd9)] - **deps**: V8: cherry-pick [`d90d453`](nodejs/node@d90d4533b053) (Michaël Zasso) [#50077](nodejs/node#50077) - \[[`9ab8c3db87`](nodejs/node@9ab8c3db87)] - **deps**: update c-ares to 1.27.0 (Node.js GitHub Bot) [#51846](nodejs/node#51846) - \[[`c688680387`](nodejs/node@c688680387)] - **deps**: update c-ares to 1.26.0 (Node.js GitHub Bot) [#51582](nodejs/node#51582) - \[[`9498ac8a47`](nodejs/node@9498ac8a47)] - **deps**: compile c-ares with C11 support (Michaël Zasso) [#51410](nodejs/node#51410) - \[[`8fb743642f`](nodejs/node@8fb743642f)] - **deps**: update c-ares to 1.25.0 (Node.js GitHub Bot) [#51385](nodejs/node#51385) - \[[`7bea2d7c12`](nodejs/node@7bea2d7c12)] - **deps**: update zlib to 1.3.0.1-motley-40e35a7 (Node.js GitHub Bot) [#51274](nodejs/node#51274) - \[[`57a38c8f75`](nodejs/node@57a38c8f75)] - **deps**: update zlib to 1.3.0.1-motley-dd5fc13 (Node.js GitHub Bot) [#51105](nodejs/node#51105) - \[[`b0ca084a6b`](nodejs/node@b0ca084a6b)] - **deps**: update zlib to 1.3-22124f5 (Node.js GitHub Bot) [#50910](nodejs/node#50910) - \[[`4b43823f37`](nodejs/node@4b43823f37)] - **deps**: update zlib to 1.2.13.1-motley-5daffc7 (Node.js GitHub Bot) [#50803](nodejs/node#50803) - \[[`f0da591812`](nodejs/node@f0da591812)] - **deps**: update zlib to 1.2.13.1-motley-dfc48fc (Node.js GitHub Bot) [#50456](nodejs/node#50456) - \[[`16d28a883a`](nodejs/node@16d28a883a)] - **deps**: update base64 to 0.5.2 (Node.js GitHub Bot) [#51455](nodejs/node#51455) - \[[`13a9e81cb6`](nodejs/node@13a9e81cb6)] - **deps**: update base64 to 0.5.1 (Node.js GitHub Bot) [#50629](nodejs/node#50629) - \[[`b4502d3ac5`](nodejs/node@b4502d3ac5)] - **deps**: update simdutf to 4.0.8 (Node.js GitHub Bot) [#51000](nodejs/node#51000) - \[[`183cf8a74a`](nodejs/node@183cf8a74a)] - **deps**: update simdutf to 4.0.4 (Node.js GitHub Bot) [#50772](nodejs/node#50772) - \[[`11ba8593ea`](nodejs/node@11ba8593ea)] - **deps**: update ada to 2.7.6 (Node.js GitHub Bot) [#51542](nodejs/node#51542) - \[[`73a946d55c`](nodejs/node@73a946d55c)] - **deps**: update ada to 2.7.5 (Node.js GitHub Bot) [#51542](nodejs/node#51542) - \[[`cc434c1a39`](nodejs/node@cc434c1a39)] - **deps**: update ada to 2.7.4 (Node.js GitHub Bot) [#50815](nodejs/node#50815) - \[[`3a3808a6ae`](nodejs/node@3a3808a6ae)] - **deps**: upgrade npm to 10.5.0 (npm team) [#51913](nodejs/node#51913) - \[[`c8876d765c`](nodejs/node@c8876d765c)] - **deps**: upgrade npm to 10.3.0 (npm team) [#51431](nodejs/node#51431) - \[[`5aec3af460`](nodejs/node@5aec3af460)] - **deps**: update corepack to 0.25.2 (Node.js GitHub Bot) [#51810](nodejs/node#51810) - \[[`a593985326`](nodejs/node@a593985326)] - **deps**: update corepack to 0.24.1 (Node.js GitHub Bot) [#51459](nodejs/node#51459) - \[[`d1a9237bf5`](nodejs/node@d1a9237bf5)] - **deps**: update corepack to 0.24.0 (Node.js GitHub Bot) [#51318](nodejs/node#51318) - \[[`adac0c7a63`](nodejs/node@adac0c7a63)] - **deps**: update corepack to 0.23.0 (Node.js GitHub Bot) [#50563](nodejs/node#50563) - \[[`4a6f83e32a`](nodejs/node@4a6f83e32a)] - **deps**: escape Python strings correctly (Michaël Zasso) [#50695](nodejs/node#50695) - \[[`c13969e52a`](nodejs/node@c13969e52a)] - **deps**: V8: cherry-pick [`ea996ad`](nodejs/node@ea996ad04a68) (Nicolò Ribaudo) [#51136](nodejs/node#51136) - \[[`6fbf0ba5c3`](nodejs/node@6fbf0ba5c3)] - **deps**: V8: cherry-pick [`a0fd320`](nodejs/node@a0fd3209dda8) (Nicolò Ribaudo) [#51136](nodejs/node#51136) - \[[`68fd7516e1`](nodejs/node@68fd7516e1)] - **deps**: update timezone to 2024a (Michaël Zasso) [#51723](nodejs/node#51723) - \[[`f9b229ebe1`](nodejs/node@f9b229ebe1)] - **deps**: update icu to 74.2 (Michaël Zasso) [#51723](nodejs/node#51723) - \[[`90c73d2eb4`](nodejs/node@90c73d2eb4)] - **deps**: update timezone to 2023d (Node.js GitHub Bot) [#51461](nodejs/node#51461) - \[[`2a2bf57028`](nodejs/node@2a2bf57028)] - **deps**: update icu to 74.1 (Node.js GitHub Bot) [#50515](nodejs/node#50515) - \[[`425e011e52`](nodejs/node@425e011e52)] - **deps**: add v8::Object::SetInternalFieldForNodeCore() (Joyee Cheung) [#49874](nodejs/node#49874) - \[[`58c70344a2`](nodejs/node@58c70344a2)] - **deps**: V8: cherry-pick [`705e374`](nodejs/node@705e374124ae) (Joyee Cheung) [#51004](nodejs/node#51004) - \[[`b0e88899e1`](nodejs/node@b0e88899e1)] - **deps**: V8: cherry-pick [`1fada6b`](nodejs/node@1fada6b36f8d) (Joyee Cheung) [#51004](nodejs/node#51004) - \[[`d87a810b81`](nodejs/node@d87a810b81)] - **deps**: V8: cherry-pick [`3dd9576`](nodejs/node@3dd9576ce336) (Joyee Cheung) [#51004](nodejs/node#51004) - \[[`6d50966876`](nodejs/node@6d50966876)] - **deps**: V8: cherry-pick [`94e8282`](nodejs/node@94e8282325a1) (Joyee Cheung) [#51004](nodejs/node#51004) - \[[`fafbacdfec`](nodejs/node@fafbacdfec)] - **deps**: V8: cherry-pick [`9a98f96`](nodejs/node@9a98f96b6d68) (Joyee Cheung) [#51004](nodejs/node#51004) - \[[`d4a530ed8d`](nodejs/node@d4a530ed8d)] - **deps**: V8: cherry-pick [`7f5daed`](nodejs/node@7f5daed62d47) (Joyee Cheung) [#51004](nodejs/node#51004) - \[[`1ce901b164`](nodejs/node@1ce901b164)] - **deps**: V8: cherry-pick [`c400af4`](nodejs/node@c400af48b5ef) (Joyee Cheung) [#51004](nodejs/node#51004) - \[[`f232064f35`](nodejs/node@f232064f35)] - **doc**: fix historical experimental fetch flag (Kenrick) [#51506](nodejs/node#51506) - \[[`194ff6a40f`](nodejs/node@194ff6a40f)] - **(SEMVER-MINOR)** **doc**: add deprecation notice to `dirent.path` (Antoine du Hamel) [#50976](nodejs/node#50976) - \[[`0f09267dc6`](nodejs/node@0f09267dc6)] - **(SEMVER-MINOR)** **doc**: deprecate `dirent.path` (Antoine du Hamel) [#50976](nodejs/node#50976) - \[[`8bfb8f5b2f`](nodejs/node@8bfb8f5b2f)] - **doc,crypto**: further clarify RSA_PKCS1\_PADDING support (Tobias Nießen) [#51799](nodejs/node#51799) - \[[`c7baf7b274`](nodejs/node@c7baf7b274)] - **doc,crypto**: add changelog and note about disabled RSA_PKCS1\_PADDING (Filip Skokan) [#51782](nodejs/node#51782) - \[[`a193be3dc2`](nodejs/node@a193be3dc2)] - **esm**: use import attributes instead of import assertions (Antoine du Hamel) [#50140](nodejs/node#50140) - \[[`26e8f7793e`](nodejs/node@26e8f7793e)] - **(SEMVER-MINOR)** **fs**: introduce `dirent.parentPath` (Antoine du Hamel) [#50976](nodejs/node#50976) - \[[`5b5e5192f7`](nodejs/node@5b5e5192f7)] - **lib**: fix compileFunction throws range error for negative numbers (Jithil P Ponnan) [#49855](nodejs/node#49855) - \[[`7552de6806`](nodejs/node@7552de6806)] - **module**: fix the leak in SourceTextModule and ContextifySript (Joyee Cheung) [#48510](nodejs/node#48510) - \[[`2e05cf1c60`](nodejs/node@2e05cf1c60)] - **module**: fix leak of vm.SyntheticModule (Joyee Cheung) [#48510](nodejs/node#48510) - \[[`a86a2e14a3`](nodejs/node@a86a2e14a3)] - **module**: use symbol in WeakMap to manage host defined options (Joyee Cheung) [#48510](nodejs/node#48510) - \[[`32906ddcac`](nodejs/node@32906ddcac)] - **node-api**: segregate nogc APIs from rest via type system (Gabriel Schulhof) [#50060](nodejs/node#50060) - \[[`1aa71c26ff`](nodejs/node@1aa71c26ff)] - **node-api**: factor out common code into macros (Gabriel Schulhof) [#50664](nodejs/node#50664) - \[[`3d0b233f52`](nodejs/node@3d0b233f52)] - **node-api**: introduce experimental feature flags (Gabriel Schulhof) [#50991](nodejs/node#50991) - \[[`96514a8b9f`](nodejs/node@96514a8b9f)] - **src**: iterate on import attributes array correctly (Michaël Zasso) [#50703](nodejs/node#50703) - \[[`2c2892bf88`](nodejs/node@2c2892bf88)] - **src**: set ModuleWrap internal fields only once (Joyee Cheung) [#49391](nodejs/node#49391) - \[[`ff334cb774`](nodejs/node@ff334cb774)] - **src**: cast v8::Object::GetInternalField() return value to v8::Value (Joyee Cheung) [#48943](nodejs/node#48943) - \[[`270b519971`](nodejs/node@270b519971)] - **stream**: do not defer construction by one microtick (Matteo Collina) [#52005](nodejs/node#52005) - \[[`95d7a75084`](nodejs/node@95d7a75084)] - **test**: fix dns test case failures after c-ares update to 1.21.0+ (Brad House) [#50743](nodejs/node#50743) - \[[`cd613e5167`](nodejs/node@cd613e5167)] - **test**: handle relative https redirect (Richard Lau) [#51121](nodejs/node#51121) - \[[`40f10eafcf`](nodejs/node@40f10eafcf)] - **test**: fix `internet/test-inspector-help-page` (Richard Lau) [#51693](nodejs/node#51693) - \[[`5e426511b1`](nodejs/node@5e426511b1)] - **test**: deflake test-vm-contextified-script-leak (Joyee Cheung) [#49710](nodejs/node#49710) - \[[`0b156c6d28`](nodejs/node@0b156c6d28)] - **test**: use checkIfCollectable in vm leak tests (Joyee Cheung) [#49671](nodejs/node#49671) - \[[`1586c11b3c`](nodejs/node@1586c11b3c)] - **test**: add checkIfCollectable to test/common/gc.js (Joyee Cheung) [#49671](nodejs/node#49671) - \[[`902d8b3d4b`](nodejs/node@902d8b3d4b)] - **test**: fix flaky http-chunk-extensions-limit test (Ethan Arrowood) [#51943](nodejs/node#51943) - \[[`1743d2bdc1`](nodejs/node@1743d2bdc1)] - **test**: test surrogate pair filenames on windows (Mert Can Altın) [#51800](nodejs/node#51800) - \[[`1c1a7ec22d`](nodejs/node@1c1a7ec22d)] - **test**: increase platform timeout zlib-brotli-16gb (Rafael Gonzaga) [#51792](nodejs/node#51792) - \[[`931d02fe3e`](nodejs/node@931d02fe3e)] - **test, v8**: fix wrong import attributes test (Nicolò Ribaudo) [#52184](nodejs/node#52184) - \[[`d9ea6c1f8d`](nodejs/node@d9ea6c1f8d)] - **tls**: fix order of setting cipher before setting cert and key (Kumar Rishav) [#50186](nodejs/node#50186) - \[[`3184befa2e`](nodejs/node@3184befa2e)] - **tools**: fix update-icu.sh (Michaël Zasso) [#51723](nodejs/node#51723) - \[[`06646e11be`](nodejs/node@06646e11be)] - **(SEMVER-MINOR)** **vm**: use import attributes instead of import assertions (Antoine du Hamel) [#50141](nodejs/node#50141) - \[[`fe66e9d06e`](nodejs/node@fe66e9d06e)] - **vm**: reject in importModuleDynamically without --experimental-vm-modules (Joyee Cheung) [#50137](nodejs/node#50137) - \[[`052e095c6b`](nodejs/node@052e095c6b)] - **vm**: use internal versions of compileFunction and Script (Joyee Cheung) [#50137](nodejs/node#50137) - \[[`9f7899ed0a`](nodejs/node@9f7899ed0a)] - **vm**: unify host-defined option generation in vm.compileFunction (Joyee Cheung) [#50137](nodejs/node#50137) - \[[`6291c107d0`](nodejs/node@6291c107d0)] - **vm**: use default HDO when importModuleDynamically is not set (Joyee Cheung) [#49950](nodejs/node#49950) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://harton.dev/cinder/cinder-space/pulls/25 Co-authored-by: Renovate Bot <bot@harton.nz> Co-committed-by: Renovate Bot <bot@harton.nz>

deps: update base64 to 0.5.1

5fc2959

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Nov 8, 2023

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2023

deps: update Base64 SIMD library

fcfcbff

Update the Base64 SIMD library which include new features of AVX512 support and AVX inline assembly and several bug fixes. Fixes: #45089

lpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 8, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2023

lpinca approved these changes Nov 8, 2023

View reviewed changes

github-actions bot mentioned this pull request Nov 9, 2023

CI Reliability 2023-11-09 nodejs/reliability#712

Open

20 tasks

VoltrexKeyva approved these changes Nov 9, 2023

View reviewed changes

Uzlopak approved these changes Nov 9, 2023

View reviewed changes

github-actions bot mentioned this pull request Nov 10, 2023

CI Reliability 2023-11-10 nodejs/reliability#713

Open

18 tasks

anonrig approved these changes Nov 10, 2023

View reviewed changes

richardlau approved these changes Nov 10, 2023

View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 10, 2023

github-actions bot mentioned this pull request Nov 11, 2023

CI Reliability 2023-11-11 nodejs/reliability#714

Open

27 tasks

lpinca closed this Nov 11, 2023

github-actions bot mentioned this pull request Nov 12, 2023

CI Reliability 2023-11-12 nodejs/reliability#715

Open

18 tasks

targos mentioned this pull request Nov 12, 2023

v21.2.0 release proposal #50681

Merged

github-actions bot mentioned this pull request Nov 13, 2023

CI Reliability 2023-11-13 nodejs/reliability#716

Open

24 tasks

zcbenz mentioned this pull request Nov 13, 2023

build: fix GN configuration for deps/base64 #50696

Merged

UlisesGascon mentioned this pull request Dec 12, 2023

v20.11.0 proposal #51124

Merged

targos deleted the actions/tools-update-base64 branch December 23, 2023 10:25

codebytere added a commit to electron/electron that referenced this pull request Jan 10, 2024

deps: update base64 to 0.5.1

9f09186

nodejs/node#50629

zcbenz pushed a commit to electron/electron that referenced this pull request Jan 12, 2024

deps: update base64 to 0.5.1

4833296

nodejs/node#50629

zcbenz pushed a commit to electron/electron that referenced this pull request Jan 12, 2024

deps: update base64 to 0.5.1

5d3b535

nodejs/node#50629

codebytere added a commit to electron/electron that referenced this pull request Jan 15, 2024

deps: update base64 to 0.5.1

af83940

nodejs/node#50629

codebytere added a commit to electron/electron that referenced this pull request Jan 15, 2024

deps: update base64 to 0.5.1

70799b5

nodejs/node#50629

codebytere added a commit to electron/electron that referenced this pull request Jan 16, 2024

deps: update base64 to 0.5.1

d5ef462

nodejs/node#50629

codebytere added a commit to electron/electron that referenced this pull request Jan 18, 2024

deps: update base64 to 0.5.1

eb76825

nodejs/node#50629

jkleinsc pushed a commit to electron/electron that referenced this pull request Jan 18, 2024

deps: update base64 to 0.5.1

3164a24

nodejs/node#50629

codebytere added a commit to electron/electron that referenced this pull request Jan 18, 2024

deps: update base64 to 0.5.1

bfa6285

nodejs/node#50629

richardlau mentioned this pull request Mar 20, 2024

v18.20.0 proposal #52165

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update base64 to 0.5.1 #50629

deps: update base64 to 0.5.1 #50629

nodejs-github-bot commented Nov 8, 2023 •

edited by lpinca

Loading

nodejs-github-bot commented Nov 8, 2023

lpinca commented Nov 8, 2023

richardlau commented Nov 8, 2023

lpinca commented Nov 8, 2023 •

edited

Loading

nodejs-github-bot commented Nov 8, 2023

lpinca left a comment

nodejs-github-bot commented Nov 9, 2023

Uzlopak left a comment

nodejs-github-bot commented Nov 10, 2023

PR-URL: #50629
Fixes: #50561
Fixes: #45091
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Richard Lau rlau@redhat.com

lpinca commented Nov 11, 2023

deps: update base64 to 0.5.1 #50629

deps: update base64 to 0.5.1 #50629

Conversation

nodejs-github-bot commented Nov 8, 2023 • edited by lpinca Loading

nodejs-github-bot commented Nov 8, 2023

lpinca commented Nov 8, 2023

richardlau commented Nov 8, 2023

lpinca commented Nov 8, 2023 • edited Loading

nodejs-github-bot commented Nov 8, 2023

lpinca left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 9, 2023

Uzlopak left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 10, 2023

PR-URL: #50629 Fixes: #50561 Fixes: #45091 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: Richard Lau rlau@redhat.com

lpinca commented Nov 11, 2023

nodejs-github-bot commented Nov 8, 2023 •

edited by lpinca

Loading

lpinca commented Nov 8, 2023 •

edited

Loading

PR-URL: #50629
Fixes: #50561
Fixes: #45091
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Richard Lau rlau@redhat.com