Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark SEA tests as flaky on PowerPC #50750

Closed
wants to merge 3 commits into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Nov 15, 2023

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 15, 2023
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2023
@richardlau
Copy link
Member

richardlau commented Nov 15, 2023

Is this flaking/failing on main as well (I saw the reports of it crashing for the 20.10.0 proposal)?

@joyeecheung
Copy link
Member Author

yes: nodejs/reliability#718

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2023
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

I was curious that the updated doc also says the tests are skipped on s390x but they're not in the sequential.status file which is also updated in this PR -- it looks like for the single-executable-application tests there is a whole skipIfSingleExecutableIsNotSupported function:

node/test/common/sea.js

Lines 11 to 46 in 59b27d6

function skipIfSingleExecutableIsNotSupported() {
if (!process.config.variables.single_executable_application)
common.skip('Single Executable Application support has been disabled.');
if (!['darwin', 'win32', 'linux'].includes(process.platform))
common.skip(`Unsupported platform ${process.platform}.`);
if (process.platform === 'linux' && process.config.variables.is_debug === 1)
common.skip('Running the resultant binary fails with `Couldn\'t read target executable"`.');
if (process.config.variables.node_shared)
common.skip('Running the resultant binary fails with ' +
'`/home/iojs/node-tmp/.tmp.2366/sea: error while loading shared libraries: ' +
'libnode.so.112: cannot open shared object file: No such file or directory`.');
if (process.config.variables.icu_gyp_path === 'tools/icu/icu-system.gyp')
common.skip('Running the resultant binary fails with ' +
'`/home/iojs/node-tmp/.tmp.2379/sea: error while loading shared libraries: ' +
'libicui18n.so.71: cannot open shared object file: No such file or directory`.');
if (!process.config.variables.node_use_openssl || process.config.variables.node_shared_openssl)
common.skip('Running the resultant binary fails with `Node.js is not compiled with OpenSSL crypto support`.');
if (process.config.variables.want_separate_host_toolset !== 0)
common.skip('Running the resultant binary fails with `Segmentation fault (core dumped)`.');
if (process.platform === 'linux') {
const osReleaseText = readFileSync('/etc/os-release', { encoding: 'utf-8' });
const isAlpine = /^NAME="Alpine Linux"/m.test(osReleaseText);
if (isAlpine) common.skip('Alpine Linux is not supported.');
if (process.arch === 's390x') {
common.skip('On s390x, postject fails with `memory access out of bounds`.');
}
}
}

@joyeecheung
Copy link
Member Author

Oh cool, I forgot about this helper, not sure what we should put in as the skip reasons though, maybe "On PowerPC, loading SEA results in SIGSEGV that's under investigation"?

@richardlau
Copy link
Member

The SEA tests on PPC64 are not consistently crashing -- if they were https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/buildTimeTrend would be more red. So should these be marked flaky rather than skipped?

@joyeecheung
Copy link
Member Author

Switched to marking as flaky on PowerPC.

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2023
@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau changed the title test, doc: skip SEA tests on PowerPC test: mark SEA tests as flaky on PowerPC Nov 16, 2023
Co-authored-by: Richard Lau <rlau@redhat.com>
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2023
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Nov 17, 2023
PR-URL: #50750
Refs: #50740
Refs: nodejs/reliability#718
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson
Copy link
Member

Landed in 136742d

@joyeecheung
Copy link
Member Author

It looks like we do need ppc64 instead of ppc https://ci.nodejs.org/job/node-test-commit-plinux/50941/

targos pushed a commit that referenced this pull request Nov 21, 2023
PR-URL: #50750
Refs: #50740
Refs: nodejs/reliability#718
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Nov 23, 2023
PR-URL: #50750
Refs: #50740
Refs: nodejs/reliability#718
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
PR-URL: nodejs#50750
Refs: nodejs#50740
Refs: nodejs/reliability#718
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
PR-URL: nodejs#50750
Refs: nodejs#50740
Refs: nodejs/reliability#718
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
PR-URL: #50750
Refs: #50740
Refs: nodejs/reliability#718
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
PR-URL: #50750
Refs: #50740
Refs: nodejs/reliability#718
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@joyeecheung joyeecheung mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants