Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move to for of loop in test-http-hostname-typechecking.js #50782

Merged
merged 1 commit into from
Dec 22, 2023
Merged

test: move to for of loop in test-http-hostname-typechecking.js #50782

merged 1 commit into from
Dec 22, 2023

Conversation

Puppo
Copy link
Contributor

@Puppo Puppo commented Nov 18, 2023 •
edited by marco-ippolito
Loading

your first node.js contribution workshop

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2023
@ShogunPanda
Copy link
Contributor

Could you please add the file name in the commit message?

@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55742/

@Puppo Puppo force-pushed the refactor/test-http-hostname-typechecking branch from 664697b to 9cfac4a Compare November 18, 2023 18:02
@Puppo Puppo changed the title test: replace foreach to for of loop test: replace foreach with for of loop test-http-hostname-typechecking.js Nov 18, 2023
@Puppo Puppo force-pushed the refactor/test-http-hostname-typechecking branch from 9cfac4a to 8aa4665 Compare November 18, 2023 18:06
@Puppo
Copy link
Contributor Author

Puppo commented Nov 18, 2023

@ShogunPanda done ✅

@Puppo Puppo force-pushed the refactor/test-http-hostname-typechecking branch from 8aa4665 to c4f84d6 Compare November 21, 2023 12:53
@Puppo Puppo changed the title test: replace foreach with for of loop test-http-hostname-typechecking.js test: move to for of loop in test-http-hostname-typechecking.js Nov 21, 2023
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55896/

@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2023
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56437/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56453/

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2023
@nodejs-github-bot nodejs-github-bot merged commit c9fe4b6 into nodejs:main Dec 22, 2023
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c9fe4b6

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@Puppo @RafaelGSS
test: move to for of loop in test-http-hostname-typechecking.js
88e8651 
PR-URL: #50782
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@Puppo @richardlau
test: move to for of loop in test-http-hostname-typechecking.js
7f301e0 
PR-URL: #50782
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Puppo @ShogunPanda @nodejs-github-bot @RafaelGSS @marco-ippolito @debadree25