test: replace forEach with for-of in test-v8-serders.js #50791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
marco-ippolito
added
the
code-and-learn
jasnell
approved these changes
Nov 19, 2023
marco-ippolito
added
the
request-ci
marco-ippolito
approved these changes
Nov 20, 2023
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Nov 22, 2023
RafaelGSS
reviewed
Nov 24, 2023
There was a problem hiding this comment.
@iannonoss apparently, your commit doesn't include email and username. Can you --resetAuthor after configuring your git? (git config user.name ...)
iannonoss
force-pushed
the
for-of-iannonss
branch
from
2d73fd9
to
9b0d7b9
Compare
hi @RafaelGSS, i have just updated my pr with my user configuration. Can you let say if all thing are ok? |
|
@RafaelGSS hi, any news for this pr? Thanks in advance |
github-actions
bot
removed
the
request-ci
|
@lpinca any news for this pr? |
RafaelGSS
approved these changes
Dec 21, 2023
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in fe918f5 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #50791 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50791 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: replace forEach with for-of in test-v8-serders.js