Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: --input-type default & limitations #50796

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

shubham9411
Copy link
Contributor

Added additional details about --input-type
Fixes: #50781

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Nov 18, 2023
@shubham9411 shubham9411 force-pushed the doc-cli-input-type branch 2 times, most recently from d1ca25c to f8a79c2 Compare November 18, 2023 17:37
@tniessen
Copy link
Member

@shubham9411 Please amend the commit message to comply with our commit message guidelines.

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nodejs/loaders

doc/api/cli.md Outdated
Comment on lines 1033 to 1035
* Default input type can be altered with
[`--experimental-default-type=module`][]
* [`--print`][] does not support `--input-type=module`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Default input type can be altered with
[`--experimental-default-type=module`][]
* [`--print`][] does not support `--input-type=module`
* The default input type can be altered with
[`--experimental-default-type=module`][].
* [`--print`][] does not support `--input-type=module`.

@shubham9411
Copy link
Contributor Author

@tniessen Updated please check.

doc/api/cli.md Outdated Show resolved Hide resolved
doc/api/cli.md Outdated Show resolved Hide resolved
@aduh95 aduh95 merged commit 4b0401f into nodejs:main Dec 4, 2023
13 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Dec 4, 2023

Landed in 4b0401f

targos pushed a commit that referenced this pull request Dec 4, 2023
PR-URL: #50796
Fixes: #50781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@targos targos mentioned this pull request Dec 4, 2023
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #50796
Fixes: #50781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document CLI --input-type default & limitations
7 participants