Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update brotli to 1.1.0 #50804

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of brotli to 1.1.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. brotli Issues and PRs related to the brotli dependency. needs-ci PRs that need a full CI run. labels Nov 19, 2023
@targos
Copy link
Member

targos commented Dec 23, 2023

Just rebased, fixed the conflict and updated the gyp file.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5e64483 into main Dec 27, 2023
51 checks passed
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-brotli branch December 27, 2023 06:29
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 5e64483

@isker
Copy link
Contributor

isker commented Dec 27, 2023

Clueless question from the peanut gallery: is this kind of change typically okay to backport to LTS? We have some compression-intensive workloads on 20.x where the supposed ~5% performance improvement included in this upgrade would be appreciated.

@lpinca
Copy link
Member

lpinca commented Dec 27, 2023

is this kind of change typically okay to backport to LTS?

Yes, it will be backported.

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #50804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
nodejs-github-bot pushed a commit that referenced this pull request Jan 7, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: nodejs#51373
Refs: nodejs#50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: nodejs#51373
Refs: nodejs#50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #50804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau added a commit that referenced this pull request Mar 25, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #50804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau added a commit that referenced this pull request Mar 25, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
aduh95 pushed a commit that referenced this pull request Nov 3, 2024
PR-URL: #50804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brotli Issues and PRs related to the brotli dependency. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants