-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: update iterations in benchmark/crypto/get-ciphers.js #50863
Conversation
You already updated the |
I have updated that PR removing ciphers, and also updated the commit msg of this PR. Could you please go ahead to approve this PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
Landed in 1b16bf6 |
Increase the 500 iteration to 50000 to reflect the real ciphers perf. The single iteration n=1 can not make the score reasonable.
Refs: #50571
before:
crypto/get-ciphers.js v="crypto" n=1: 1,852.3492419260726
crypto/get-ciphers.js v="tls" n=1: 1,405.8034377517265
crypto/get-ciphers.js v="crypto" n=5000: 6,147,294.084090065
crypto/get-ciphers.js v="tls" n=5000: 4,488,971.047034541
after
crypto/get-ciphers.js v="crypto" n=1: 1,879.232972270038
crypto/get-ciphers.js v="tls" n=1: 1,430.8526164570944
crypto/get-ciphers.js v="crypto" n=500000: 9,035,846.449813219
crypto/get-ciphers.js v="tls" n=500000: 19,212,295.13113179