Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: update iterations in benchmark/crypto/get-ciphers.js #50863

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

lucshi
Copy link

@lucshi lucshi commented Nov 23, 2023

Increase the 500 iteration to 50000 to reflect the real ciphers perf. The single iteration n=1 can not make the score reasonable.

Refs: #50571

before:
crypto/get-ciphers.js v="crypto" n=1: 1,852.3492419260726
crypto/get-ciphers.js v="tls" n=1: 1,405.8034377517265
crypto/get-ciphers.js v="crypto" n=5000: 6,147,294.084090065
crypto/get-ciphers.js v="tls" n=5000: 4,488,971.047034541

after
crypto/get-ciphers.js v="crypto" n=1: 1,879.232972270038
crypto/get-ciphers.js v="tls" n=1: 1,430.8526164570944
crypto/get-ciphers.js v="crypto" n=500000: 9,035,846.449813219
crypto/get-ciphers.js v="tls" n=500000: 19,212,295.13113179

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem. labels Nov 23, 2023
@H4ad
Copy link
Member

H4ad commented Nov 26, 2023

@lucshi
Copy link
Author

lucshi commented Nov 27, 2023

You already updated the get-ciphers at: https://github.com/nodejs/node/pull/50861/files#diff-18aec8a200905e49e047c06939918db3ef51e9d59bd868b72139b5989a47247eR6

I have updated that PR removing ciphers, and also updated the commit msg of this PR. Could you please go ahead to approve this PR. Thanks!

@lucshi lucshi changed the title benchmark: increase iteration number to appropriate one benchmark: update iterations in benchmark/crypto/get-ciphers.js Nov 27, 2023
Copy link
Member

@H4ad H4ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

H4ad

This comment was marked as duplicate.

@H4ad H4ad added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 2, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1b16bf6 into nodejs:main Dec 2, 2023
23 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1b16bf6

targos pushed a commit that referenced this pull request Dec 4, 2023
Fixes: #50571
PR-URL: #50863
Refs: #50571
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@targos targos mentioned this pull request Dec 4, 2023
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Fixes: #50571
PR-URL: #50863
Refs: #50571
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants