Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add doc for Unix abstract socket #50904

Merged
merged 1 commit into from
Nov 28, 2023
Merged

doc: add doc for Unix abstract socket #50904

merged 1 commit into from
Nov 28, 2023

Conversation

theanarkh
Copy link
Contributor

Refs: #49667

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Nov 25, 2023
@theanarkh theanarkh added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2023
@nodejs-github-bot nodejs-github-bot merged commit 69866bf into nodejs:main Nov 28, 2023
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 69866bf

targos pushed a commit that referenced this pull request Dec 4, 2023
@theanarkh @targos
doc: add doc for Unix abstract socket
eecab88 
PR-URL: #50904
Refs: #49667
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@targos targos mentioned this pull request Dec 4, 2023
Merged
@zobo
Copy link
Contributor

zobo commented Mar 11, 2024

I think it should be added that abstract UNIX sockets are actually working only on versions >=v20.8.0

@theanarkh theanarkh mentioned this pull request Mar 11, 2024
Merged
4 tasks
@theanarkh
Copy link
Contributor Author

theanarkh commented Mar 11, 2024 •
edited
Loading

I think it should be added that abstract UNIX sockets are actually working only on versions >=v20.8.0

Thanks ! I have opened a PR to add this.

nodejs-github-bot pushed a commit that referenced this pull request Mar 19, 2024
@theanarkh
doc: optimize the doc about Unix abstract socket
7071554 
PR-URL: #52043
Refs: #50904
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@theanarkh @richardlau
doc: add doc for Unix abstract socket
5f8e7a0 
PR-URL: #50904
Refs: #49667
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@theanarkh @rdw-msft
doc: optimize the doc about Unix abstract socket
26a34df 
PR-URL: nodejs#52043
Refs: nodejs#50904
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@theanarkh @marco-ippolito
doc: optimize the doc about Unix abstract socket
7857cfb 
PR-URL: #52043
Refs: #50904
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@theanarkh @marco-ippolito
doc: optimize the doc about Unix abstract socket
bda3cde 
PR-URL: #52043
Refs: #50904
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theanarkh @nodejs-github-bot @zobo @ShogunPanda @lpinca