Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: resolve flakiness in worker*.test-free-called #51013

Merged

Conversation

MrJithil
Copy link
Member

@MrJithil MrJithil commented Dec 2, 2023

Fixes: #51003

The issue arises from the getFreeCallCount() function yielding the initial value of 0. Upon instantiation of the Worker object, it increments to 1. In the case of this flaky test, if the creation of the Worker object is faster, the subsequent getFreeCallCount() call always returns 1 instead of the expected 0.

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 2, 2023
@MrJithil MrJithil force-pushed the fix-51003-test-free-called-is-flaky branch 4 times, most recently from 164741e to c306d18 Compare December 2, 2023 06:03
@MrJithil MrJithil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 6, 2023
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2023
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the right subsystem should be “test:”

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 7, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/51013
✔  Done loading data for nodejs/node/pull/51013
----------------------------------- PR info ------------------------------------
Title      fix: resolve flakiness in worker*.test-free-called (#51013)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     MrJithil:fix-51003-test-free-called-is-flaky -> nodejs:main
Labels     test, addons, author ready, needs-ci
Commits    1
 - test: fix flakiness in worker*.test-free-called
Committers 1
 - Jithil P Ponnan 
PR-URL: https://github.com/nodejs/node/pull/51013
Fixes: https://github.com/nodejs/node/issues/51003
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51013
Fixes: https://github.com/nodejs/node/issues/51003
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 02 Dec 2023 05:44:01 GMT
   ✔  Approvals: 3
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51013#pullrequestreview-1760948847
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1769070609
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51013#pullrequestreview-1770962147
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-12-07T11:14:40Z: https://ci.nodejs.org/job/node-test-pull-request/56149/
- Querying data for job/node-test-pull-request/56149/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 51013
From https://github.com/nodejs/node
 * branch                  refs/pull/51013/merge -> FETCH_HEAD
✔  Fetched commits as 42b238ec9ac2..c306d1832849
--------------------------------------------------------------------------------
[main 8b345bdba2] test: fix flakiness in worker*.test-free-called
 Author: Jithil P Ponnan 
 Date: Sat Dec 2 13:36:19 2023 +0800
 1 file changed, 3 insertions(+), 1 deletion(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
   ✘  Git found no trailers in the original commit message, but 'Fixes: https://github.com/nodejs/node/issues/51003' is present and should be a trailer.
https://github.com/nodejs/node/actions/runs/7134450198

@MrJithil MrJithil added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/51013
✔  Done loading data for nodejs/node/pull/51013
----------------------------------- PR info ------------------------------------
Title      fix: resolve flakiness in worker*.test-free-called (#51013)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     MrJithil:fix-51003-test-free-called-is-flaky -> nodejs:main
Labels     test, addons, author ready, needs-ci
Commits    1
 - test: fix flakiness in worker*.test-free-called
Committers 1
 - Jithil P Ponnan 
PR-URL: https://github.com/nodejs/node/pull/51013
Fixes: https://github.com/nodejs/node/issues/51003
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51013
Fixes: https://github.com/nodejs/node/issues/51003
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 02 Dec 2023 05:44:01 GMT
   ✔  Approvals: 3
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51013#pullrequestreview-1760948847
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1769070609
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51013#pullrequestreview-1770962147
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-12-07T21:57:04Z: https://ci.nodejs.org/job/node-test-pull-request/56149/
- Querying data for job/node-test-pull-request/56149/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 51013
From https://github.com/nodejs/node
 * branch                  refs/pull/51013/merge -> FETCH_HEAD
✔  Fetched commits as 1ba508d51b30..c306d1832849
--------------------------------------------------------------------------------
[main 311f4b7b68] test: fix flakiness in worker*.test-free-called
 Author: Jithil P Ponnan 
 Date: Sat Dec 2 13:36:19 2023 +0800
 1 file changed, 3 insertions(+), 1 deletion(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
   ✘  Git found no trailers in the original commit message, but 'Fixes: https://github.com/nodejs/node/issues/51003' is present and should be a trailer.
https://github.com/nodejs/node/actions/runs/7148604463

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 9, 2023
The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.

Fixes: nodejs#51003
@MrJithil MrJithil force-pushed the fix-51003-test-free-called-is-flaky branch from c306d18 to 2bf498c Compare December 9, 2023 05:32
@MrJithil MrJithil changed the title fix: resolve flakiness in worker*.test-free-called test: resolve flakiness in worker*.test-free-called Dec 9, 2023
@MrJithil MrJithil added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 9, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 9, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/51013
✔  Done loading data for nodejs/node/pull/51013
----------------------------------- PR info ------------------------------------
Title      test: resolve flakiness in worker*.test-free-called (#51013)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     MrJithil:fix-51003-test-free-called-is-flaky -> nodejs:main
Labels     test, addons, author ready, needs-ci
Commits    1
 - test: fix flakiness in worker*.test-free-called
Committers 1
 - Jithil P Ponnan 
PR-URL: https://github.com/nodejs/node/pull/51013
Fixes: https://github.com/nodejs/node/issues/51003
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51013
Fixes: https://github.com/nodejs/node/issues/51003
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 02 Dec 2023 05:44:01 GMT
   ✔  Approvals: 4
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51013#pullrequestreview-1773785072
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1769070609
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51013#pullrequestreview-1770962147
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1773716931
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-12-09T02:57:36Z: https://ci.nodejs.org/job/node-test-pull-request/56149/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - test: fix flakiness in worker*.test-free-called
- Querying data for job/node-test-pull-request/56149/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/7152874215

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2023
@nodejs-github-bot

This comment was marked as duplicate.

@nodejs-github-bot

This comment was marked as duplicate.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@debadree25 debadree25 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 13, 2023
@nodejs-github-bot
Copy link
Collaborator

@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit 64f7d0e into nodejs:main Dec 19, 2023
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 64f7d0e

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.

Fixes: #51003
PR-URL: #51013
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.

Fixes: #51003
PR-URL: #51013
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky - addons.worker-buffer-callback.test-free-called
8 participants