-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: resolve flakiness in worker*.test-free-called #51013
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
MrJithil:fix-51003-test-free-called-is-flaky
Dec 19, 2023
Merged
test: resolve flakiness in worker*.test-free-called #51013
nodejs-github-bot
merged 1 commit into
nodejs:main
from
MrJithil:fix-51003-test-free-called-is-flaky
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
addons
Issues and PRs related to native addons.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Dec 2, 2023
MrJithil
force-pushed
the
fix-51003-test-free-called-is-flaky
branch
4 times, most recently
from
December 2, 2023 06:03
164741e
to
c306d18
Compare
H4ad
approved these changes
Dec 2, 2023
MrJithil
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 6, 2023
joyeecheung
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the right subsystem should be “test:”
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 7, 2023
lpinca
approved these changes
Dec 7, 2023
H4ad
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 7, 2023
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Dec 7, 2023
Commit Queue failed- Loading data for nodejs/node/pull/51013 ✔ Done loading data for nodejs/node/pull/51013 ----------------------------------- PR info ------------------------------------ Title fix: resolve flakiness in worker*.test-free-called (#51013) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MrJithil:fix-51003-test-free-called-is-flaky -> nodejs:main Labels test, addons, author ready, needs-ci Commits 1 - test: fix flakiness in worker*.test-free-called Committers 1 - Jithil P Ponnan PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 02 Dec 2023 05:44:01 GMT ✔ Approvals: 3 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51013#pullrequestreview-1760948847 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1769070609 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51013#pullrequestreview-1770962147 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-12-07T11:14:40Z: https://ci.nodejs.org/job/node-test-pull-request/56149/ - Querying data for job/node-test-pull-request/56149/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51013 From https://github.com/nodejs/node * branch refs/pull/51013/merge -> FETCH_HEAD ✔ Fetched commits as 42b238ec9ac2..c306d1832849 -------------------------------------------------------------------------------- [main 8b345bdba2] test: fix flakiness in worker*.test-free-called Author: Jithil P Ponnan Date: Sat Dec 2 13:36:19 2023 +0800 1 file changed, 3 insertions(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- ✘ Git found no trailers in the original commit message, but 'Fixes: https://github.com/nodejs/node/issues/51003' is present and should be a trailer.https://github.com/nodejs/node/actions/runs/7134450198 |
MrJithil
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Dec 9, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 9, 2023
Commit Queue failed- Loading data for nodejs/node/pull/51013 ✔ Done loading data for nodejs/node/pull/51013 ----------------------------------- PR info ------------------------------------ Title fix: resolve flakiness in worker*.test-free-called (#51013) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MrJithil:fix-51003-test-free-called-is-flaky -> nodejs:main Labels test, addons, author ready, needs-ci Commits 1 - test: fix flakiness in worker*.test-free-called Committers 1 - Jithil P Ponnan PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 02 Dec 2023 05:44:01 GMT ✔ Approvals: 3 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51013#pullrequestreview-1760948847 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1769070609 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51013#pullrequestreview-1770962147 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-12-07T21:57:04Z: https://ci.nodejs.org/job/node-test-pull-request/56149/ - Querying data for job/node-test-pull-request/56149/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51013 From https://github.com/nodejs/node * branch refs/pull/51013/merge -> FETCH_HEAD ✔ Fetched commits as 1ba508d51b30..c306d1832849 -------------------------------------------------------------------------------- [main 311f4b7b68] test: fix flakiness in worker*.test-free-called Author: Jithil P Ponnan Date: Sat Dec 2 13:36:19 2023 +0800 1 file changed, 3 insertions(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- ✘ Git found no trailers in the original commit message, but 'Fixes: https://github.com/nodejs/node/issues/51003' is present and should be a trailer.https://github.com/nodejs/node/actions/runs/7148604463 |
nodejs-github-bot
added
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Dec 9, 2023
The issue arises from the `getFreeCallCount()` function yielding the initial value of 0. Upon instantiation of the `Worker` object, it increments to 1. In the case of this flaky test, if the creation of the `Worker` object is faster, the subsequent `getFreeCallCount()` call always returns 1 instead of the expected 0. Fixes: nodejs#51003
MrJithil
force-pushed
the
fix-51003-test-free-called-is-flaky
branch
from
December 9, 2023 05:32
c306d18
to
2bf498c
Compare
MrJithil
changed the title
fix: resolve flakiness in worker*.test-free-called
test: resolve flakiness in worker*.test-free-called
Dec 9, 2023
jasnell
approved these changes
Dec 9, 2023
MrJithil
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Dec 9, 2023
H4ad
approved these changes
Dec 9, 2023
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Dec 9, 2023
Commit Queue failed- Loading data for nodejs/node/pull/51013 ✔ Done loading data for nodejs/node/pull/51013 ----------------------------------- PR info ------------------------------------ Title test: resolve flakiness in worker*.test-free-called (#51013) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MrJithil:fix-51003-test-free-called-is-flaky -> nodejs:main Labels test, addons, author ready, needs-ci Commits 1 - test: fix flakiness in worker*.test-free-called Committers 1 - Jithil P Ponnan PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 02 Dec 2023 05:44:01 GMT ✔ Approvals: 4 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51013#pullrequestreview-1773785072 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1769070609 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51013#pullrequestreview-1770962147 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1773716931 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-12-09T02:57:36Z: https://ci.nodejs.org/job/node-test-pull-request/56149/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - test: fix flakiness in worker*.test-free-called - Querying data for job/node-test-pull-request/56149/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7152874215 |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 10, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
debadree25
removed
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Dec 13, 2023
UlisesGascon
approved these changes
Dec 13, 2023
H4ad
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 19, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 19, 2023
Landed in 64f7d0e |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
The issue arises from the `getFreeCallCount()` function yielding the initial value of 0. Upon instantiation of the `Worker` object, it increments to 1. In the case of this flaky test, if the creation of the `Worker` object is faster, the subsequent `getFreeCallCount()` call always returns 1 instead of the expected 0. Fixes: #51003 PR-URL: #51013 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
The issue arises from the `getFreeCallCount()` function yielding the initial value of 0. Upon instantiation of the `Worker` object, it increments to 1. In the case of this flaky test, if the creation of the `Worker` object is faster, the subsequent `getFreeCallCount()` call always returns 1 instead of the expected 0. Fixes: #51003 PR-URL: #51013 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addons
Issues and PRs related to native addons.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #51003
The issue arises from the
getFreeCallCount()
function yielding the initial value of 0. Upon instantiation of theWorker
object, it increments to 1. In the case of this flaky test, if the creation of theWorker
object is faster, the subsequentgetFreeCallCount()
call always returns 1 instead of the expected 0.