Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: set exit code in custom test runner example #51056

Merged
merged 2 commits into from
Dec 20, 2023
Merged

doc: set exit code in custom test runner example #51056

merged 2 commits into from
Dec 20, 2023

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Dec 5, 2023

No description provided.

@mcollina
doc: set exit code in custom test runner example
5d33812 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2023
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Dec 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56096/

atlowChemi
atlowChemi approved these changes Dec 5, 2023
View reviewed changes
doc/api/test.md Outdated
Comment on lines 1158 to 1159
process.exitCode = 1
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
process.exitCode = 1
})
process.exitCode = 1;
})

doc/api/test.md Outdated
@@ -1164,6 +1167,9 @@ const { run } = require('node:test');
const path = require('node:path');

run({ files: [path.resolve('./tests/test.js')] })
.on('test:fail', () => {
process.exitCode = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
process.exitCode = 1
process.exitCode = 1;

juliangruber
juliangruber suggested changes Dec 5, 2023
View reviewed changes
doc/api/test.md Outdated
@@ -1154,6 +1154,9 @@ import process from 'node:process';
import path from 'node:path';

run({ files: [path.resolve('./tests/test.js')] })
.on('test:fail', () => {
process.exitCode = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
process.exitCode = 1
process.exitCode = 1;

MoLow
MoLow approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once lint passes

@mcollina mcollina mentioned this pull request Dec 9, 2023
Merged
8 tasks
@mcollina
linting
be6094f 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56386/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56402/

@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2023
@nodejs-github-bot nodejs-github-bot merged commit c1051a0 into nodejs:main Dec 20, 2023
54 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c1051a0

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@mcollina @RafaelGSS
doc: set exit code in custom test runner example
5453abd 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #51056
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@mcollina @richardlau
doc: set exit code in custom test runner example
979e183 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #51056
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangruber juliangruber juliangruber requested changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@aymen94 aymen94 aymen94 approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mcollina @nodejs-github-bot @juliangruber @jasnell @lpinca @MoLow @aymen94 @atlowChemi