Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: deprecate hash constructor #51077

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Dec 6, 2023

Hash is an internal and shouldnt be called directly but through createHash():
https://github.com/nodejs/node/blob/main/doc/api/crypto.md#class-hash
Calling Hash without new qualifier avoids us from moving into ES6 classes.
The idea is to deprecate it, and refactor it with es6 class without exposing it.

@anonrig

@marco-ippolito marco-ippolito added the crypto Issues and PRs related to the crypto subsystem. label Dec 6, 2023
@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Dec 6, 2023
doc/api/deprecations.md Outdated Show resolved Hide resolved
@anonrig
Copy link
Member

anonrig commented Dec 6, 2023

cc @nodejs/crypto

@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2023
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit ba3f721 into nodejs:main Dec 10, 2023
19 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ba3f721

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
PR-URL: #51077
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS added a commit that referenced this pull request Dec 15, 2023
Notable changes:

deps:
  * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322
doc:
  * deprecate hash constructor (Marco Ippolito) #51077
  * deprecate `dirent.path` (Antoine du Hamel) #51020
module:
  * merge config with `package_json_reader` (Yagiz Nizipli) #50322
src:
  * move package resolver to c++ (Yagiz Nizipli) #50322

PR-URL: TBD
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
RafaelGSS added a commit that referenced this pull request Dec 15, 2023
Notable changes:

deps:
  * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322
doc:
  * deprecate hash constructor (Marco Ippolito) #51077
  * deprecate `dirent.path` (Antoine du Hamel) #51020
module:
  * merge config with `package_json_reader` (Yagiz Nizipli) #50322
src:
  * move package resolver to c++ (Yagiz Nizipli) #50322

PR-URL: #51166
RafaelGSS added a commit that referenced this pull request Dec 15, 2023
Notable changes:

deps:
  * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322
doc:
  * deprecate hash constructor (Marco Ippolito) #51077
  * deprecate `dirent.path` (Antoine du Hamel) #51020
module:
  * merge config with `package_json_reader` (Yagiz Nizipli) #50322
src:
  * move package resolver to c++ (Yagiz Nizipli) #50322

PR-URL: #51166
RafaelGSS added a commit that referenced this pull request Dec 19, 2023
Notable changes:

deps:
  * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322
doc:
  * deprecate hash constructor (Marco Ippolito) #51077
  * deprecate `dirent.path` (Antoine du Hamel) #51020
module:
  * merge config with `package_json_reader` (Yagiz Nizipli) #50322
src:
  * move package resolver to c++ (Yagiz Nizipli) #50322

PR-URL: #51166
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51077
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants