Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update simdjson to 3.6.3 #51104

Closed
wants to merge 1 commit into from
Closed

deps: update simdjson to 3.6.3 #51104

wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of simdjson to 3.6.3.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Dec 10, 2023
@mhdawson
Copy link
Member

@marco-ippolito we may need to run a step in the updater to run the formatter so the linter does not complain.

@marco-ippolito

This comment was marked as outdated.

Sign in to view
@marco-ippolito
Copy link
Member

marco-ippolito commented Dec 16, 2023 •
edited
Loading

So actually there is an issue with the maintaining dependencies script, there was a typo, that's why its failing
Refs: #51177

@aduh95 aduh95 force-pushed the actions/tools-update-simdjson branch from 949c587 to f9aaf46 Compare December 17, 2023 00:32
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/56338/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/56341/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/56344/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/56370/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/56377/

@aduh95 aduh95 force-pushed the actions/tools-update-simdjson branch from f9aaf46 to f731246 Compare December 19, 2023 10:08
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/56381/

mhdawson
mhdawson approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Dec 20, 2023
@nodejs-github-bot @mhdawson
deps: update simdjson to 3.6.3
e7d90c5 
PR-URL: #51104
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson
Copy link
Member

Landed in e7d90c5

@mhdawson mhdawson closed this Dec 20, 2023
@targos targos deleted the actions/tools-update-simdjson branch December 23, 2023 10:24
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@nodejs-github-bot @RafaelGSS
deps: update simdjson to 3.6.3
a07d6e2 
PR-URL: #51104
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
@marco-ippolito marco-ippolito added the backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@mhdawson mhdawson mhdawson approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nodejs-github-bot @mhdawson @marco-ippolito @UlisesGascon @aduh95