[v20.x backport] fs: add stacktrace to fs/promises #51127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
sapphi-red
force-pushed
the
backport-49849-to-v20.x
branch
from
119b5ee
to
3a1ee22
Compare
sapphi-red
added a commit
to sapphi-red/node
that referenced
this pull request
Dec 12, 2023
Sync functions in fs throwed an error with a stacktrace which is helpful for debugging. But functions in fs/promises throwed an error without a stacktrace. This commit adds stacktraces by calling Error.captureStacktrace and re-throwing the error. Refs: nodejs#34817 PR-URL: nodejs#49849 Backport-PR-URL: nodejs#51127 Fixes: nodejs#50160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
The lint error is not caused by this PR. |
UlisesGascon
force-pushed
the
v20.x-staging
branch
from
a300366
to
423c757
Compare
The lint issue was solved in c519e80 🙌 |
sapphi-red
force-pushed
the
backport-49849-to-v20.x
branch
from
3a1ee22
to
61766a7
Compare
sapphi-red
added a commit
to sapphi-red/node
that referenced
this pull request
Dec 12, 2023
Sync functions in fs throwed an error with a stacktrace which is helpful for debugging. But functions in fs/promises throwed an error without a stacktrace. This commit adds stacktraces by calling Error.captureStacktrace and re-throwing the error. Refs: nodejs#34817 PR-URL: nodejs#49849 Backport-PR-URL: nodejs#51127 Fixes: nodejs#50160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
Rebased on top of it 👍 |
UlisesGascon
force-pushed
the
v20.x-staging
branch
2 times, most recently
from
7ee5261
to
4c9099f
Compare
UlisesGascon
force-pushed
the
v20.x-staging
branch
from
4c9099f
to
7af8e20
Compare
UlisesGascon
force-pushed
the
v20.x-staging
branch
from
a42629c
to
435f9c9
Compare
|
This needs to be rebased. |
sapphi-red
force-pushed
the
backport-49849-to-v20.x
branch
from
61766a7
to
c4d58e7
Compare
sapphi-red
added a commit
to sapphi-red/node
that referenced
this pull request
Mar 26, 2024
Sync functions in fs throwed an error with a stacktrace which is helpful for debugging. But functions in fs/promises throwed an error without a stacktrace. This commit adds stacktraces by calling Error.captureStacktrace and re-throwing the error. Refs: nodejs#34817 PR-URL: nodejs#49849 Backport-PR-URL: nodejs#51127 Fixes: nodejs#50160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sync functions in fs throwed an error with a stacktrace which is helpful for debugging. But functions in fs/promises throwed an error without a stacktrace. This commit adds stacktraces by calling Error.captureStacktrace and re-throwing the error. Refs: nodejs#34817 PR-URL: nodejs#49849 Backport-PR-URL: nodejs#51127 Fixes: nodejs#50160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
sapphi-red
force-pushed
the
backport-49849-to-v20.x
branch
from
c4d58e7
to
518d819
Compare
github-actions
bot
removed
the
request-ci
RafaelGSS
force-pushed
the
v20.x-staging
branch
from
ae243ec
to
32014f5
Compare
marco-ippolito
approved these changes
Apr 29, 2024
marco-ippolito
force-pushed
the
v20.x-staging
branch
from
4fd1691
to
ecadd63
Compare
RafaelGSS
approved these changes
Apr 29, 2024
marco-ippolito
pushed a commit
that referenced
this pull request
Apr 29, 2024
Sync functions in fs throwed an error with a stacktrace which is helpful for debugging. But functions in fs/promises throwed an error without a stacktrace. This commit adds stacktraces by calling Error.captureStacktrace and re-throwing the error. Refs: #34817 PR-URL: #49849 Backport-PR-URL: #51127 Fixes: #50160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
Landed in c530520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backport of #49849.
Sync functions in fs throwed an error with a stacktrace which is helpful for debugging. But functions in fs/promises throwed an error without a stacktrace. This commit adds stacktraces by calling Error.captureStacktrace and re-throwing the error.
Refs: #34817
PR-URL: #49849
Fixes: #50160
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Zeyu "Alex" Yang himself65@outlook.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Jiawen Geng technicalcute@gmail.com