src,stream: Improve WriteString #51155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Introduce HasDoTryWrite and make use of it in WriteString
ywave620
force-pushed
the
improve-WriteString
branch
from
2c9047b
to
6d48cec
Compare
remove extra ;
tniessen
reviewed
Dec 15, 2023
Add comment
Update comment
|
@tniessen Could you rerun the ci :) |
|
Could anyone help push this forward? Actually, I think this is a non trivial change, given that it removes an unnecessary memory copy for the very hot case, TLSWrap::WriteString |
github-actions
bot
removed
the
request-ci
lpinca
added
author ready
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 461ffca |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
Introduce HasDoTryWrite and make use of it in WriteString PR-URL: #51155 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Introduce HasDoTryWrite and make use of it in WriteString PR-URL: #51155 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Introduce HasDoTryWrite and make use of it in WriteString PR-URL: #51155 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce HasDoTryWrite in order to eliminate the unnecessary memory copy in WriteString for StreamBase not overriding DoTryWrite, e.g. TLSWrap, HTTP2Session