-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: remove misleading warning #51204
Conversation
There are cases where the `'clientError'` event can be emitted multiple times, even if the socket is correctly destroyed. Fixes: nodejs#51073
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Nice work, thanks @lpinca! I can imagine other solutions to fix this, like batching client errors, but one way or another they'd end up changing more sensitive existing behaviour elsewhere, so just dropping the incorrect warning seems much simpler.
Sorry, I don't understand this. If we remove this, we will reopen #43548. Or am I missing anything? |
Oh, I see. Makes sense now. Thanks! |
Landed in 30f8ef1 |
There are cases where the
'clientError'
event can be emitted multiple times, even if the socket is correctly destroyed.Fixes: #51073