Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: remove misleading warning #51204

Merged
merged 2 commits into from
Dec 21, 2023
Merged

http: remove misleading warning #51204

merged 2 commits into from
Dec 21, 2023

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Dec 18, 2023

There are cases where the 'clientError' event can be emitted multiple times, even if the socket is correctly destroyed.

Fixes: #51073

@lpinca
http: remove misleading warning
5c6976b 
There are cases where the `'clientError'` event can be emitted multiple
times, even if the socket is correctly destroyed.

Fixes: nodejs#51073
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Dec 18, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56361/

mcollina
mcollina approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56368/

pimterry
pimterry reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Nice work, thanks @lpinca! I can imagine other solutions to fix this, like batching client errors, but one way or another they'd end up changing more sensitive existing behaviour elsewhere, so just dropping the incorrect warning seems much simpler.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56384/

@lpinca lpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56392/

@ShogunPanda
Copy link
Contributor

Sorry, I don't understand this. If we remove this, we will reopen #43548. Or am I missing anything?

@lpinca
Copy link
Member Author

lpinca commented Dec 20, 2023 •
edited
Loading

If we remove this, we will reopen #43548.

No, the fix for #43548 is still there. We added the warning because we could not reproduce the issue in a legit way. We can now and the warning is misleading.

@ShogunPanda
Copy link
Contributor

Oh, I see. Makes sense now. Thanks!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56406/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 30f8ef1 into nodejs:main Dec 21, 2023
57 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 30f8ef1

@lpinca lpinca deleted the remove/warning branch December 21, 2023 20:09
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@lpinca @RafaelGSS
http: remove misleading warning
c7a1359 
There are cases where the `'clientError'` event can be emitted multiple
times, even if the socket is correctly destroyed.

Fixes: #51073
PR-URL: #51204
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jan 29, 2024
Closed
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@lpinca @richardlau
http: remove misleading warning
f7b53d0 
There are cases where the `'clientError'` event can be emitted multiple
times, even if the socket is correctly destroyed.

Fixes: #51073
PR-URL: #51204
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
@si458 si458 mentioned this pull request Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimterry pimterry pimterry left review comments

@aymen94 aymen94 aymen94 approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP server can report clientError misuse warning even when socket is destroyed correctly
6 participants
@lpinca @nodejs-github-bot @ShogunPanda @mcollina @pimterry @aymen94