Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mention node:wasi in the Threat Model #51211

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

RafaelGSS
Copy link
Member

Following up: #50396 (comment)

cc: @mhdawson

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 19, 2023
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/51211
✔  Done loading data for nodejs/node/pull/51211
----------------------------------- PR info ------------------------------------
Title      doc: mention node:wasi in the Threat Model (#51211)
Author     Rafael Gonzaga  (@RafaelGSS)
Branch     RafaelGSS:document-wasi-threat-model -> nodejs:main
Labels     doc
Commits    1
 - doc: mention node:wasi in the Threat Model
Committers 1
 - RafaelGSS 
PR-URL: https://github.com/nodejs/node/pull/51211
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51211
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 19 Dec 2023 00:52:31 GMT
   ✔  Approvals: 1
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/51211#pullrequestreview-1791240304
   ✘  This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/7282751023

@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit a71210b into nodejs:main Dec 21, 2023
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a71210b

RafaelGSS added a commit that referenced this pull request Jan 2, 2024
PR-URL: #51211
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51211
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants