Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add URL tests to fs-read in pm #51213

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

RafaelGSS
Copy link
Member

Just to guarantee URLs are being transformed into paths before the permission model (pm) check.

@RafaelGSS RafaelGSS added test Issues and PRs related to the tests. permission Issues and PRs related to the Permission Model labels Dec 19, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 19, 2023
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@nodejs-github-bot
Copy link
Collaborator

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 335ecda into nodejs:main Dec 21, 2023
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 335ecda

RafaelGSS added a commit that referenced this pull request Jan 2, 2024
PR-URL: #51213
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This was referenced Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51213
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants