Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: add missing jsdoc parameters to readSync #51225

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fs: add missing jsdoc parameters to readSync #51225

merged 1 commit into from
Dec 21, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Dec 19, 2023

Adds missing optional JSDoc parameters to fs.readFile

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Dec 19, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56404/

@aduh95
Copy link
Contributor

aduh95 commented Dec 20, 2023

@anonrig FYI there's no need for CI for typings changes as they only touch comments.

node/doc/contributing/collaborator-guide.md

Lines 216 to 220 in 62fc950

Changes in the following folders (except comment-only changes) are guaranteed to
affect the `node` binary:
* `deps/`
* `lib/`

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 20, 2023
@aduh95 aduh95 merged commit 5155238 into nodejs:main Dec 21, 2023
57 of 61 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Dec 21, 2023

Landed in 5155238

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@anonrig @RafaelGSS
fs: add missing jsdoc parameters to readSync
c87e5d5 
PR-URL: #51225
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@anonrig @richardlau
fs: add missing jsdoc parameters to readSync
721557c 
PR-URL: #51225
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@trivikr trivikr trivikr approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anonrig @nodejs-github-bot @aduh95 @trivikr @marco-ippolito