Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Memory Usage by Hoisting Function in For Loop 💽 #51242

Merged
merged 4 commits into from
Dec 23, 2023

Conversation

sanjaiyan-dev
Copy link
Contributor

Hi, this pull request introduces a very minor improvement in memory usage by hoisting the function outside the for loop. This adjustment offers benefits such as reducing the overhead of redefining the function in each iteration, resulting in a more optimized and efficient code execution.

Extremely sorry, if I made any mistakes :)

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 20, 2023
lib/internal/per_context/primordials.js Outdated Show resolved Hide resolved
lib/internal/per_context/primordials.js Outdated Show resolved Hide resolved
sanjaiyan-dev and others added 2 commits December 21, 2023 00:20
Fix variable naming

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fix variable naming

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 merged commit b8fe07d into nodejs:main Dec 23, 2023
53 of 54 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Dec 23, 2023

Landed in b8fe07d

@sanjaiyan-dev sanjaiyan-dev deleted the sanjaiyan-memory-optimization branch December 23, 2023 02:31
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51242
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51242
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants