Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix use of --frozen-intrinsics with --jitless #51248

Merged
merged 2 commits into from
Dec 23, 2023
Merged

lib: fix use of --frozen-intrinsics with --jitless #51248

merged 2 commits into from
Dec 23, 2023
+14 −9

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 21, 2023

Fixes: #51232

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 21, 2023
@aduh95 @targos
Update lib/internal/freeze_intrinsics.js
a7d624d 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2023 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/56440/ 💛

@H4ad H4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit 825163c into nodejs:main Dec 23, 2023
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 825163c

@aduh95 aduh95 deleted the frozen-intrinsics-jitless branch December 23, 2023 23:34
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@aduh95 @RafaelGSS
lib: fix use of --frozen-intrinsics with --jitless
6241429 
PR-URL: #51248
Fixes: #51232
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@aduh95 @richardlau
lib: fix use of --frozen-intrinsics with --jitless
562947e 
PR-URL: #51248
Fixes: #51232
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--jitless and --frozen-intrinsics options can not be combined
7 participants
@aduh95 @nodejs-github-bot @jasnell @lpinca @targos @richardlau @H4ad