Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace forEach with for-of in test-webcrypto-export-import-ec #51249

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

cricciardi
Copy link
Contributor

test: replace forEach with for-of in test-webcrypto-export-import-ec

@marco-ippolito

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 21, 2023
@marco-ippolito marco-ippolito added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2023

@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 21, 2023
Copy link
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 22, 2023
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2023
@nodejs-github-bot nodejs-github-bot merged commit ba957a6 into nodejs:main Dec 22, 2023
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ba957a6

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51249
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51249
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants