Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: pass invalidSubtypeIndex instead of trimmedSubtype to error #51264

Merged
merged 1 commit into from
Dec 25, 2023
Merged

util: pass invalidSubtypeIndex instead of trimmedSubtype to error #51264

merged 1 commit into from
Dec 25, 2023

Conversation

gaurishhs
Copy link
Contributor

Followup from: #49711

The error ERR_INVALID_MIME_SYNTAX expects the invalid index which wasn't being passed.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 23, 2023
@gaurishhs gaurishhs mentioned this pull request Dec 23, 2023
Closed
@targos
Copy link
Member

targos commented Dec 23, 2023

Is there a way to test this?

@gaurishhs
Copy link
Contributor Author

Is there a way to test this?

#50577

Might help

@deokjinkim deokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56504/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56518/

@deokjinkim deokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6a1abd2 into nodejs:main Dec 25, 2023
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6a1abd2

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@gaurishhs @RafaelGSS
util: pass invalidSubtypeIndex instead of trimmedSubtype to error
f4f781d 
PR-URL: #51264
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@gaurishhs @richardlau
util: pass invalidSubtypeIndex instead of trimmedSubtype to error
f79ac33 
PR-URL: #51264
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deokjinkim deokjinkim deokjinkim approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaurishhs @targos @nodejs-github-bot @lpinca @deokjinkim