Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VScode "Reopen in Container" #51271

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Fix VScode "Reopen in Container" #51271

merged 1 commit into from
Dec 31, 2023

Conversation

ohhmm
Copy link
Contributor

@ohhmm ohhmm commented Dec 23, 2023

Make "Reopen in Container" command work in Visual Studio code.

Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be correct, based off this documentation. My understanding is that there's not a really great way to test something like this without merging - happy to be told I'm wrong, but this LGTM as the person who originally built the devcontainer.

If it's not, I'm happy to take responsibility for fixing it 👍🏻

Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 26, 2023
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5fb6305 into nodejs:main Dec 31, 2023
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5fb6305

@ohhmm ohhmm deleted the dockerfix branch December 31, 2023 11:18
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51271
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51271
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51271
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants