-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VScode "Reopen in Container" #51271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be correct, based off this documentation. My understanding is that there's not a really great way to test something like this without merging - happy to be told I'm wrong, but this LGTM as the person who originally built the devcontainer.
If it's not, I'm happy to take responsibility for fixing it 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Landed in 5fb6305 |
PR-URL: #51271 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #51271 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #51271 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Make "Reopen in Container" command work in Visual Studio code.