Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: disallow mixed spaces and tabs for indents #5135

Closed
wants to merge 2 commits into from
Closed

tools: disallow mixed spaces and tabs for indents #5135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a03fb2
tools: alphabetize eslint stylistic issues section
Trott Feb 8, 2016
d7dca68
tools: disallow mixed spaces and tabs for indents
Trott Feb 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,36 +55,38 @@ rules:

# Stylistic Issues
# list: https://github.com/eslint/eslint/tree/master/docs/rules#stylistic-issues
## use single quote, we can use double quote when escape chars
quotes: [2, "single", "avoid-escape"]
## 2 space indentation
indent: [2, 2, {SwitchCase: 1}]
## add space after comma
comma-spacing: 2
## put semi-colon
semi: 2
## require spaces operator like var sum = 1 + 1;
space-infix-ops: 2
## require spaces return, throw, case
space-return-throw-case: 2
## no space before function, eg. 'function()'
space-before-function-paren: [2, "never"]
## require space before blocks, eg 'function() {'
space-before-blocks: [2, "always"]
## require parens for Constructor
new-parens: 2
## require newline at end of files
eol-last: 2
## 2 space indentation
indent: [2, 2, {SwitchCase: 1}]
## max 80 length
max-len: [2, 80, 2]
## require parens for Constructor
new-parens: 2
## disallow mixed spaces and tabs for indentation
no-mixed-spaces-and-tabs: 2
## max 2 consecutive empty lines
no-multiple-empty-lines: [2, {max: 2}]
## require newline at end of files
eol-last: 2
## no trailing spaces
no-trailing-spaces: 2
## use single quote, we can use double quote when escape chars
quotes: [2, "single", "avoid-escape"]
## put semi-colon
semi: 2
## require space after keywords, eg 'for (..)'
space-after-keywords: 2
## require space before blocks, eg 'function() {'
space-before-blocks: [2, "always"]
## no space before function, eg. 'function()'
space-before-function-paren: [2, "never"]
## no leading/trailing spaces in parens
space-in-parens: [2, "never"]
## require spaces operator like var sum = 1 + 1;
space-infix-ops: 2
## require spaces return, throw, case
space-return-throw-case: 2
## no spaces with non-word unary operators, require for word unary operators
space-unary-ops: 2

Expand Down
14 changes: 8 additions & 6 deletions test/parallel/test-crypto-certificate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,16 @@ var certificate = new crypto.Certificate();
assert.equal(certificate.verifySpkac(spkacValid), true);
assert.equal(certificate.verifySpkac(spkacFail), false);

assert.equal(stripLineEndings(certificate.exportPublicKey(spkacValid)
.toString('utf8')),
stripLineEndings(spkacPem.toString('utf8')));
assert.equal(
stripLineEndings(certificate.exportPublicKey(spkacValid).toString('utf8')),
stripLineEndings(spkacPem.toString('utf8'))
);
assert.equal(certificate.exportPublicKey(spkacFail), '');

assert.equal(certificate.exportChallenge(spkacValid)
.toString('utf8'),
'fb9ab814-6677-42a4-a60c-f905d1a6924d');
assert.equal(
certificate.exportChallenge(spkacValid).toString('utf8'),
'fb9ab814-6677-42a4-a60c-f905d1a6924d'
);
assert.equal(certificate.exportChallenge(spkacFail), '');

function stripLineEndings(obj) {
Expand Down