-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix flaky conditions for ppc64 SEA tests #51422
Conversation
@@ -47,8 +47,9 @@ test-watch-mode-inspect: SKIP | |||
# https://github.com/nodejs/node/issues/41286 | |||
test-performance-eventloopdelay: PASS, FLAKY | |||
|
|||
[$system==ppc || $system==ppc64] | |||
[$system==linux && $arch==ppc64] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re. $arch
and the confusion in the previous PR's -- it looks like this should match process.arch
:
Lines 1676 to 1688 in e0b159e
archEngineContext = Execute([vm, "-p", "process.arch"], context) | |
vmArch = archEngineContext.stdout.rstrip() | |
if archEngineContext.exit_code != 0 or vmArch == "undefined": | |
print("Can't determine the arch of: '%s'" % vm) | |
print(archEngineContext.stderr.rstrip()) | |
continue | |
env = { | |
'mode': mode, | |
'system': utils.GuessOS(), | |
'arch': vmArch, | |
'type': get_env_type(vm, options.type, context), | |
'asan': get_asan_state(), | |
} |
which on ppc64le is
ppc64
:
[iojs@test-osuosl-rhel8-ppc64--le-2 ~]$ ./build/workspace/node-test-commit-plinux/nodes/rhel8-ppc64le/out/Release/node -p process.arch
ppc64
[iojs@test-osuosl-rhel8-ppc64--le-2 ~]$
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le.
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
This comment was marked as outdated.
This comment was marked as outdated.
FWIW https://ci.nodejs.org/job/node-test-commit-plinux/51647/nodes=rhel8-ppc64le/ is a CI on a temporary branch that is the current v21.6.0-proposal branch with the commit for this PR cherry-picked on top. The six failing single-executable-application tests are marked flaky and the job is overall marked yellow/unstable (as opposed to red/failed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment was marked as outdated.
This comment was marked as outdated.
Landed in 273c892 |
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: #51422 Refs: #50828 Refs: #50740 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: nodejs#51422 Refs: nodejs#50828 Refs: nodejs#50740 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: nodejs#51422 Refs: nodejs#50828 Refs: nodejs#50740 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: #51422 Refs: #50828 Refs: #50740 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: #51422 Refs: #50828 Refs: #50740 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
In test status files,
$system
will be the OS and not the arch (which would be$arch
).Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le.
Refs: #50828
Refs: #50740