doc: remove reference to resolved child_process v8 issue #51467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: nodejs#48523 Refs: nodejs/performance#138
nodejs-github-bot
added
child_process
|
I could remove the entire paragraph, as it was added all at once, but I figure the bit I've left is not wrong. Let me know if you think it should be removed. |
kvakil
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Thanks, I missed this line! Can you delete the paragraph entirely? It's obviously true that any asynchronous operation will "perform[] memory operations synchronously", the previous wording made sense as a way of emphasizing a particularly large cost which I think is no longer necessary to mention.
|
Done. |
kvakil
approved these changes
Jan 17, 2024
kvakil
added
the
author ready
lpinca
approved these changes
Jan 17, 2024
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/51467 ✔ Done loading data for nodejs/node/pull/51467 ----------------------------------- PR info ------------------------------------ Title doc: remove reference to resolved child_process v8 issue (#51467) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch isker:patch-2 -> nodejs:main Labels child_process, doc, author ready Commits 2 - doc: remove reference to resolved child_process v8 issue - Update child_process.md Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/51467 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: https://github.com/nodejs/node/pull/48523 Refs: https://github.com/nodejs/performance/issues/138 Reviewed-By: Keyhan Vakil Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51467 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: https://github.com/nodejs/node/pull/48523 Refs: https://github.com/nodejs/performance/issues/138 Reviewed-By: Keyhan Vakil Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 15 Jan 2024 03:47:37 GMT ✔ Approvals: 2 ✔ - Keyhan Vakil (@kvakil): https://github.com/nodejs/node/pull/51467#pullrequestreview-1826255104 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51467#pullrequestreview-1828022124 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51467 From https://github.com/nodejs/node * branch refs/pull/51467/merge -> FETCH_HEAD ✔ Fetched commits as 6ab15a1aa8de..9cca93061688 -------------------------------------------------------------------------------- [main cfaf7262ca] doc: remove reference to resolved child_process v8 issue Author: Ian Kerins Date: Sun Jan 14 22:46:09 2024 -0500 1 file changed, 1 insertion(+), 3 deletions(-) [main b51f83b9b7] Update child_process.md Author: Ian Kerins Date: Wed Jan 17 01:44:46 2024 +0000 1 file changed, 4 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/7560845377 |
debadree25
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eb4432c |
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: nodejs#48523 Refs: nodejs/performance#138 PR-URL: nodejs#51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 22, 2024
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: nodejs#48523 Refs: nodejs/performance#138 PR-URL: nodejs#51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 2, 2024
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: nodejs#48523 Refs: nodejs/performance#138 PR-URL: nodejs#51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: #48523 Refs: nodejs/performance#138 PR-URL: #51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 19, 2024
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: nodejs#48523 Refs: nodejs/performance#138 PR-URL: nodejs#51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: #48523 Refs: nodejs/performance#138 PR-URL: #51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: #48523 Refs: nodejs/performance#138 PR-URL: #51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue.
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381
Refs: #48523
Refs: nodejs/performance#138