doc: fix dns.lookup and dnsPromises.lookup description #51517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The family option and all option have wrong description. Fixes: #51482
|
Review requested:
|
nodejs-github-bot
added
dns
ShogunPanda
requested changes
Jan 19, 2024
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
ShogunPanda
requested changes
Jan 26, 2024
There was a problem hiding this comment.
Minor things are pointed out in #51517 (comment).
After that, it LGTM!
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
lpinca
reviewed
Jan 27, 2024
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
ShogunPanda
approved these changes
Jan 29, 2024
ShogunPanda
approved these changes
Jan 29, 2024
|
Linter is failing |
|
Is there something similar to |
aduh95
previously approved these changes
Jan 30, 2024
aduh95
added
the
author ready
|
Landed in 0f461aa |
|
Thanks to all for the work & take attention to my PR. |
|
This isn't correct, as dicussed in #51482 and #51483 (comment) We either need to make sure node actually has this behaviour, or revert this docs commit as this is taking it from ambigious to wrong :/ |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Feb 9, 2024
PR-URL: nodejs#51517 Fixes: nodejs#51482 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 19, 2024
PR-URL: nodejs#51517 Fixes: nodejs#51482 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #51482
Continue on: #51483