Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: don't update URL immediately on update to URLSearchParams #51520

Merged
merged 18 commits into from
Jan 24, 2024
Merged

url: don't update URL immediately on update to URLSearchParams #51520

merged 18 commits into from
Jan 24, 2024

Commits on Jan 19, 2024

  1. url: remove #context from URLSearchParams

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    2b2d11b View commit details
    Browse the repository at this point in the history

  2. url: rely on URLSearchParams if in use for search

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    129a1a9 View commit details
    Browse the repository at this point in the history

  3. url: update URLSearchParams directly from URL search setter

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c2e8526 View commit details
    Browse the repository at this point in the history

  4. url: create href using searchParams without bindingUrl call

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    039380e View commit details
    Browse the repository at this point in the history

  5. url: ensure ? is present when relying on URLSearchParams

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    e015de2 View commit details
    Browse the repository at this point in the history

  6. url: don't use public getter for toString/toJSON 

    This appears to keep the "calling stringifier with this = {} didn't throw TypeError" test happy
    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    2487726 View commit details
    Browse the repository at this point in the history

  7. url: update searchParams tests to expect encoded results

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b0270bc View commit details
    Browse the repository at this point in the history

  8. url: only use URLSearchParams as store when modified

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    d9c5381 View commit details
    Browse the repository at this point in the history

  9. url: store search in URL on first access/update after URLSearchParams… 

    … updates
    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    a05675c View commit details
    Browse the repository at this point in the history

  10. url: add benchmark for param append for URL and URLSearchParams

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    310d275 View commit details
    Browse the repository at this point in the history

  11. url: add benchmark to check impact of searchParams checking

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b118a90 View commit details
    Browse the repository at this point in the history

  12. url: reduce diff for changes

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    916374e View commit details
    Browse the repository at this point in the history

  13. url: more comments to explain lazy searchParams updating

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    319eaa0 View commit details
    Browse the repository at this point in the history

  14. url: cleanup from review 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @MattIPv4 @aduh95
    MattIPv4 and aduh95 authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0c44fb6 View commit details
    Browse the repository at this point in the history

  15. url: update variable naming, add more comments, include hash in bench… 

    …mark
    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    065c45c View commit details
    Browse the repository at this point in the history

  16. url: add tests to ensure lazy URLSearchParams is exercised

    @MattIPv4
    MattIPv4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0d0fef8 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. url: fix updating url hash etc. after searchParams update, add test

    @MattIPv4
    MattIPv4 committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    e9c4da2 View commit details
    Browse the repository at this point in the history

  2. url: update tests for invalid this

    @MattIPv4
    MattIPv4 committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    04f53a7 View commit details
    Browse the repository at this point in the history