test: migrate messages v8 tests from Python to JS #51534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated messages v8 tests from Python to JavaScript. This change is part of an effort to enhance maintainability and consistency in the test suite. All relevant test files and dependencies have been updated accordingly. Refs: nodejs#47707
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
|
Hey just wondering, are the failing tests actually related to changes introduced in this PR? |
Comment on lines
+12
to
+18
| at Object.<anonymous> (*assert_throws_stack.js:*:*) | ||
| at Module._compile (node:internal*modules*cjs*loader:*:*) | ||
| at Module._extensions..js (node:internal*modules*cjs*loader:*:*) | ||
| at Module.load (node:internal*modules*cjs*loader:*:*) | ||
| at Module._load (node:internal*modules*cjs*loader:*:*) | ||
| at Function.executeUserEntryPoint [as runMain] (node:internal*modules*run_main:*:*) | ||
| at node:internal*main*run_main_module:*:* { |
There was a problem hiding this comment.
We need to get all of this out of the snapshot, so that changes to the CommonJS loader don’t break tests such as this one. You can use Error.stackTraceLimit = 1 or similar for this (see the similar tests nearby).
Comment on lines
+7
to
+12
| at makeContextifyScript (node:internal*vm:*:*) | ||
| at node:internal*process*execution:*:* | ||
| at [eval]-wrapper:*:* | ||
| at runScript (node:internal*process*execution:*:*) | ||
| at evalScript (node:internal*process*execution:*:*) | ||
| at node:internal*main*eval_string:*:* |
Probably not, especially if they happen only on certain platforms. We generally click “resume” a few times to rerun CI because many tests are flaky. Sorry for not getting to this sooner! Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated messages v8 tests from Python to JavaScript. This change is part of an effort to enhance maintainability and consistency in the test suite. All relevant test files and dependencies have been updated accordingly.
Refs: #47707
Summary
This pull request addresses Issue #47707, which involved migrating messages v8 tests from Python to JavaScript to enhance maintainability and consistency in the test suite.
Changes Made
Additional Notes
Tests affected:
Related Issues
Improves: Issue #47707
Checklist